Bug 1811807 Comment 1 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Exploration results from the PerfTools Cluj Workweek: 
- The API for the ProfilerBuffer & ProfilerChunkedStorage is not very amenable to taking references (or views?) to parts of a buffer. We need to implement something that looks like a view onto a buffer, and pass that around instead of a small buffer.
- The existing code that writes to a profiler buffer while stackwalking needs a threadsafe buffer (platform.cpp:2916), but the main buffer is not threadsafe.
Exploration results from the PerfTools Cluj Workweek: 
- The API for the ProfilerBuffer & ProfilerChunkedStorage is not very amenable to taking references (or views?) to parts of a buffer. We need to implement something that looks like a view onto a buffer, and pass that around instead of a small buffer.
- The existing code that writes to a profiler buffer while stackwalking needs a threadsafe buffer (platform.cpp:2916), but the main buffer is not threadsafe.
- It may be that our current buffer implementation isn't amenable to this. We may need a lock-free buffer to allow markers to write to it. 
- An alternative might be having two separate buffers for markers and samples?

Back to Bug 1811807 Comment 1