Bug 1811950 Comment 10 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Adding dependency on bug 1072107 which is where this code was added -- in particular, "part 8" there had CreateForWorker with the `return nullptr` early-return (the code that I quoted in comment 4):
https://hg.mozilla.org/mozilla-central/rev/d45228a652b44ada5ca749bd36e8b0399153302e#l1.30

...and "part 9 there added a callsite which asserts that it never returns null (the code that I quoted in comment 9):
https://hg.mozilla.org/mozilla-central/rev/7eecad7fdee1d234f2d4d77e4b7cedfbe62ed7c6#l6.64

Those need to be harmonized somehow, in addition to making `FontFaceSet` safely-destructable.

(I'll also revert my naive reclassification to put this under Layout:Text&Fonts, too -- it looks like CSS is the appropriate component, since that matches bug 1072107 where all this code was added.  Sorry for the churn.)
Adding dependency on bug 1072107 which is where this code was added -- in particular, "part 8" there had CreateForWorker with the `return nullptr` early-return (the code that I quoted in comment 4):
https://hg.mozilla.org/mozilla-central/rev/d45228a652b44ada5ca749bd36e8b0399153302e#l1.30

...and "part 9" there added a callsite which asserts that `CreateForWorker` never returns null (the code that I quoted in comment 9) even though it does in fact return null:
https://hg.mozilla.org/mozilla-central/rev/7eecad7fdee1d234f2d4d77e4b7cedfbe62ed7c6#l6.64

Those need to be harmonized somehow, in addition to making `FontFaceSet` safely-destructable.

(I'll also revert my naive reclassification to put this under Layout:Text&Fonts, too -- it looks like CSS is the appropriate component, since that matches bug 1072107 where all this code was added.  Sorry for the churn.)
Adding dependency on bug 1072107 which is where this code was added -- in particular, "part 8" there had CreateForWorker with the `return nullptr` early-return (the code that I quoted in comment 4):
https://hg.mozilla.org/mozilla-central/rev/d45228a652b44ada5ca749bd36e8b0399153302e#l1.30

...and "part 9" there added a callsite which asserts that `CreateForWorker` never returns null (the code that I quoted in comment 9) even though it does in fact sometimes return null:
https://hg.mozilla.org/mozilla-central/rev/7eecad7fdee1d234f2d4d77e4b7cedfbe62ed7c6#l6.64

Those need to be harmonized somehow, in addition to making `FontFaceSet` safely-destructable-with-null-mImpl.

(I'll also revert my naive reclassification to put this under Layout:Text&Fonts, too -- it looks like CSS is the appropriate component, since that matches bug 1072107 where all this code was added.  Sorry for the churn.)

Back to Bug 1811950 Comment 10