Bug 1814099 Comment 1 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
I can also think of a test that non-null -> replaceTrack(non-null) does switch to the new track.

In addition to checking inbound-rtp we should check that the expected pixels get rendered.

Tests for replacing a track with another with different properties would be good too.
For video: tracks with different video dimensions.
For audio: tracks with different samplerate and channel count

And why not
enabled->replaceTrack(!enabled), and
!enabled->replaceTrack(enabled)
Revision 1 by
on 
I can also think of a test that non-null -> replaceTrack(non-null) does switch to the new track.

In addition to checking inbound-rtp we should check that the expected pixels get rendered.

Tests for replacing a track with another with different properties would be good too.
For video: tracks with different video dimensions, image format (if we can?).
For audio: tracks with different samplerate and channel count

And why not
enabled->replaceTrack(!enabled), and
!enabled->replaceTrack(enabled)
Revision 2 by
on 
I can also think of a test that non-null -> replaceTrack(non-null) does switch to the new track.

In addition to checking inbound-rtp we should check that the expected pixels get rendered.

Tests for replacing a track with another with different properties would be good too.
For video: tracks with different video dimensions, image format (if we can?).
For audio: tracks with different samplerate and channel count

And why not
enabled->replaceTrack(!enabled), and
!enabled->replaceTrack(enabled)

ditto with muted

Back to Bug 1814099 Comment 1