https://www.figma.com/file/ujdiReypSypu2GhRgzArea/Android-Components?node-id=1808%3A7913&t=lbpgP5pE8qXx6YpY-0 - Support Light/Dark/Private theming - Support text only items and text + icon items The API
Bug 1816567 Comment 0 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
https://www.figma.com/file/ujdiReypSypu2GhRgzArea/Android-Components?node-id=1808%3A7913&t=lbpgP5pE8qXx6YpY-0 - Support Light/Dark/Private theming - Support text only items and text + icon items A nice-to-have would be for the API to allow for a list of menu items (whatever form that takes) to make it so it's just one function call to set up the: - Menu - Menu visibility - Menu items - Click callbacks
https://www.figma.com/file/ujdiReypSypu2GhRgzArea/Android-Components?node-id=1808%3A7913&t=lbpgP5pE8qXx6YpY-0 - Support Light/Dark/Private theming - Support text only items and text + icon items A nice-to-have would be for the API to allow for a list of menu items (whatever form that takes) to make it so it's just one function call to set up the: - Menu - Menu visibility - Menu items - Click callbacks for each item
https://www.figma.com/file/ujdiReypSypu2GhRgzArea/Android-Components?node-id=1808%3A7913&t=lbpgP5pE8qXx6YpY-0 - Support Light/Dark/Private theming - ~~Support text only items and text + icon items~~ this will be covered in another ticket A nice-to-have would be for the API to allow for a list of menu items (whatever form that takes) to make it so it's just one function call to set up the: - Menu - Menu visibility - Menu items - Click callbacks for each item As part of this ticket, please replace the existing usages of `androidx.compose.material.DropdownMenu` with our new `DropdownMenu` Composable. This [searchfox link](https://searchfox.org/mozilla-mobile/search?q=DropdownMenu(&path=) should contain them all (ignoring the references to the usages in Focus)
https://www.figma.com/file/ujdiReypSypu2GhRgzArea/Android-Components?node-id=1808%3A7913&t=lbpgP5pE8qXx6YpY-0 - Support Light/Dark/Private theming - ~~Support text only items and text + icon items~~ this will be covered in another ticket A nice-to-have would be for the API to allow for a list of menu items (whatever form that takes) to make it so it's just one function call to set up the: - Menu - Menu visibility - Menu items - Click callbacks for each item As part of this ticket, please replace the existing usages of `androidx.compose.material.DropdownMenu` with our new `DropdownMenu` Composable. This [searchfox link](https://searchfox.org/mozilla-mobile/search?q=DropdownMenu(&path=) should contain them all (ignoring the references to the usages in Focus) `RecentTabMenu` and `RecentTabMenuItem` could be some good jumping off points.