Bug 1818827 Comment 2 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Sam Foster [:sfoster] (he/him) from comment #1)
> Firefox View and the New Tab page use intentionally slightly different background colors - for better or worse. But there shouldn't be any difference between the Light theme and the System theme in light (OS appearance) mode.

With Light theme enabled, both about:newtab and about:firefoxview have #f9f9fb. But with system theme (light mode), I see #f9f9fb on about:newtab, but #fff on about:firefoxview. I'm not sure which is correct, but FWIW the Figma prototypes all seem to depict #f9f9fb. I mentioned in the first comment how the system theme's manifest doesn't have a light mode, so the colors will be drawn from stylesheets in that case. It works on about:newtab because [about:newtab has #f9f9fb hard-coded](https://searchfox.org/mozilla-central/search?q=--newtab-background-color%3A+%23F9F9FB%3B), while [about:firefoxview doesn't, and falls back to --in-content-page-background](https://searchfox.org/mozilla-central/rev/00ea1649b59d5f427979e2d6ba42be96f62d6e82/browser/components/firefoxview/firefoxview.css#42).

So the fix for this bug may just involve setting an initial value for `--newtab-background-color` on the root element, but I'm not sure what that value should be.
(In reply to Sam Foster [:sfoster] (he/him) from comment #1)
> Firefox View and the New Tab page use intentionally slightly different background colors - for better or worse. But there shouldn't be any difference between the Light theme and the System theme in light (OS appearance) mode.

With Light theme enabled, both about:newtab and about:firefoxview have #f9f9fb. But with system theme (light mode), I see #f9f9fb on about:newtab, but #fff on about:firefoxview. I'm not sure which is correct, but FWIW the Figma prototypes all seem to depict #f9f9fb. I mentioned in the first comment how the system theme's manifest doesn't have a light mode, so the colors will be drawn from stylesheets in that case. But it works on about:newtab because [about:newtab has #f9f9fb hard-coded](https://searchfox.org/mozilla-central/search?q=--newtab-background-color%3A+%23F9F9FB%3B), while [about:firefoxview doesn't, and falls back to --in-content-page-background](https://searchfox.org/mozilla-central/rev/00ea1649b59d5f427979e2d6ba42be96f62d6e82/browser/components/firefoxview/firefoxview.css#42).

So the fix for this bug may just involve setting an initial value for `--newtab-background-color` on the root element, but I'm not sure what that value should be.

Back to Bug 1818827 Comment 2