(In reply to grulja from comment #63) > I meant specifically the screen sharing code in WebRTC, which have been tested many times also on Nvidia drivers. If you have an unsually perfectly configured Nvidia driver (by enabling the Nvidia suspend service and NVreg_PreserveVideoMemoryAllocations=1), then EGL is not affected by bug 1788573 comment 26. If any dmabuf/EGLImage usage ends on suspend (shortly before) in a way that the app - after resume - doesn't let the driver try to access something that is gone, then it might not affected by bug 1788573 comment 26, but I don't know yet. Later, I will test screen sharing a bit, I think the most relevant aspect is when a preview of my screen is shown to me. At the moment, applying the dmabuf blocklist seems reasonable because why would anyone want the risk of a confirmed use-after-free EGL driver bug? My naive questions to myself are: If I open https://www.webrtc-experiment.com/Pluginfree-Screen-Sharing/ in Chromium and Firefox, there is a preview of my screen: - Is dmabuf screen sharing (actually used and) a) copied and shown like an image/canvas? That might be unaffected, but not performant. b) directly shown as if it would be dmabuf webgl? That would likely run into the problem. c) copied, software encoded, and shown as decoded video? No one would do that. - How does Chrome import a dmabuf for the preview if it actually uses GLX? Does it directly use EGL on ChromeOS (Wayland), but EGL via ANGLE via GLX on Nvidia? (Or does Chrome directly use EGL on X11 for hardware rendering - since when?)
Bug 1819035 Comment 64 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to grulja from comment #63) > I meant specifically the screen sharing code in WebRTC, which have been tested many times also on Nvidia drivers. If you have an unusually perfect configured Nvidia driver (by enabling the Nvidia suspend service and NVreg_PreserveVideoMemoryAllocations=1), then EGL is not affected by bug 1788573 comment 26. If any dmabuf/EGLImage usage ends on suspend (shortly before) in a way that the app - after resume - doesn't let the driver try to access something that is gone, then it might not affected by bug 1788573 comment 26, but I don't know yet. Later, I will test screen sharing a bit, I think the most relevant aspect is when a preview of my screen is shown to me. At the moment, applying the dmabuf blocklist seems reasonable because why would anyone want the risk of a confirmed use-after-free EGL driver bug? My naive questions to myself are: If I open https://www.webrtc-experiment.com/Pluginfree-Screen-Sharing/ in Chromium and Firefox, there is a preview of my screen: - Is dmabuf screen sharing (actually used and) a) copied and shown like an image/canvas? That might be unaffected, but not performant. b) directly shown as if it would be dmabuf webgl? That would likely run into the problem. c) copied, software encoded, and shown as decoded video? No one would do that. - How does Chrome import a dmabuf for the preview if it actually uses GLX? Does it directly use EGL on ChromeOS (Wayland), but EGL via ANGLE via GLX on Nvidia? (Or does Chrome directly use EGL on X11 for hardware rendering - since when?)