Thanks for submitting these changes! I think it should be fine to use a single observer, probably cleaner too. --- There are now two open revisions. Could you please abandon this new revision, and continue modifying the existing revision that has all of the review feedback on it? I'd like to keep everything in the same revision to preserve the history. I realize that there was probably a bit of confusion from the exceptional situation in which you were switching from Mercurial to git. The way that you can make a commit track to a specific revision is by editing the commit message to list that revision specifically. **Example** ``` commit 722a12e33758b237ce6b9fc5ff201711a1ca277c (HEAD -> phab-D194459) Author: Meera Murthy <colorcodedcrayons@gmail.com> Date: Thu Nov 23 02:00:30 2023 -0600 Bug 1819205 [translations] Translate Attributes using querySelectorAll. Add Observer for attributes. r=nordzilla! Differential Revision: https://phabricator.services.mozilla.com/D192217 ``` You will simply edit your commit message to add that bottom line, pointing it at your revision that has all of the review feedback ([D192217](https://phabricator.services.mozilla.com/D192217)), then re-submit with moz-phab. For future reference, you could have added this bottom line before submitting the first time, and it would have updated that revision instead of creating a new one. The only difference right now is that we have to abandon this new one as well. I don't expect you to have known how to do this, though, so no worries there! --- Once you get these newest changes into the correct revision, I've got some review feedback for you. Thank you for your work on this!
Bug 1819205 Comment 49 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Thanks for submitting these changes! I think it should be fine to use a single observer, probably cleaner too. --- There are now two open revisions. Could you please abandon this new revision, and continue modifying the existing revision that has all of the review feedback on it? I'd like to keep everything in the same revision to preserve the history. I realize that there was probably a bit of confusion from the exceptional situation in which you were switching from Mercurial to git. The way that you can make a commit track to a specific revision is by editing the commit message to list that revision specifically in the commit message. **Example** ``` commit 722a12e33758b237ce6b9fc5ff201711a1ca277c (HEAD -> phab-D194459) Author: Meera Murthy <colorcodedcrayons@gmail.com> Date: Thu Nov 23 02:00:30 2023 -0600 Bug 1819205 [translations] Translate Attributes using querySelectorAll. Add Observer for attributes. r=nordzilla! Differential Revision: https://phabricator.services.mozilla.com/D192217 ``` You will simply edit your commit message to add that bottom line, pointing it at your revision that has all of the review feedback ([D192217](https://phabricator.services.mozilla.com/D192217)), then re-submit with moz-phab. For future reference, you could have added this bottom line before submitting the first time, and it would have updated that revision instead of creating a new one. The only difference right now is that we have to abandon this new one as well. I don't expect you to have known how to do this, though, so no worries there! --- Once you get these newest changes into the correct revision, I've got some review feedback for you. Thank you for your work on this!
Thanks for submitting these changes! I think it should be fine to use a single observer, probably cleaner too. --- There are now two open revisions. Could you please abandon this new revision, and continue modifying the existing revision that has all of the review feedback on it? I'd like to keep everything in the same revision to preserve the history. I realize that there was probably a bit of confusion from the exceptional situation in which you were switching from Mercurial to git. The way that you can make a commit track to a specific revision is by editing the commit message to list that revision specifically in the commit message. **Example** ``` commit 722a12e33758b237ce6b9fc5ff201711a1ca277c (HEAD -> phab-D194459) Author: Meera Murthy <colorcodedcrayons@gmail.com> Date: Thu Nov 23 02:00:30 2023 -0600 Bug 1819205 [translations] Translate Attributes using querySelectorAll. Add Observer for attributes. r=nordzilla! Differential Revision: https://phabricator.services.mozilla.com/D192217 ``` You will simply edit your commit message by using `git commit --amend` to add that bottom line, pointing it at your revision that has all of the review feedback ([D192217](https://phabricator.services.mozilla.com/D192217)), then re-submit with moz-phab. For future reference, you could have added this bottom line before submitting the first time, and it would have updated that revision instead of creating a new one. The only difference right now is that we have to abandon this new one as well. I don't expect you to have known how to do this, though, so no worries there! --- Once you get these newest changes into the correct revision, I've got some review feedback for you. Thank you for your work on this!
Thanks for submitting these changes! I think it should be fine to use a single observer, probably cleaner too. --- There are now two open revisions. Could you please abandon this new revision, and continue modifying the existing revision that has all of the review feedback on it? I'd like to keep everything in the same revision to preserve the history. I realize that there was probably a bit of confusion from the exceptional situation in which you were switching from Mercurial to git. The way that you can make a commit track to a specific revision is by editing the commit message to list that revision specifically in the commit message. **Example** ``` commit 722a12e33758b237ce6b9fc5ff201711a1ca277c (HEAD -> phab-D194459) Author: Meera Murthy <colorcodedcrayons@gmail.com> Date: Thu Nov 23 02:00:30 2023 -0600 Bug 1819205 [translations] Translate Attributes using querySelectorAll. Add Observer for attributes. r=nordzilla! Differential Revision: https://phabricator.services.mozilla.com/D192217 ``` You will simply edit your commit message by using `git commit --amend` to add that bottom line, pointing it to the URL of the revision that has all of the review feedback ([D192217](https://phabricator.services.mozilla.com/D192217)), then re-submit with moz-phab. For future reference, you could have added this bottom line before submitting the first time, and it would have updated that revision instead of creating a new one. The only difference right now is that we have to abandon this new one as well. I don't expect you to have known how to do this, though, so no worries there! --- Once you get these newest changes into the correct revision, I've got some review feedback for you. Thank you for your work on this!
Thanks for submitting these changes! I think it should be fine to use a single observer, probably cleaner too. --- There are now two open revisions. Could you please abandon this new revision, and continue modifying the existing revision that has all of the review feedback on it? I'd like to keep everything in the same revision to preserve the history. I realize that there was probably a bit of confusion from the exceptional situation in which you were switching from Mercurial to git. The way that you can make a commit track to a specific revision is by editing the commit message to point at that revision specifically. **Example** ``` commit 722a12e33758b237ce6b9fc5ff201711a1ca277c (HEAD -> phab-D194459) Author: Meera Murthy <colorcodedcrayons@gmail.com> Date: Thu Nov 23 02:00:30 2023 -0600 Bug 1819205 [translations] Translate Attributes using querySelectorAll. Add Observer for attributes. r=nordzilla! Differential Revision: https://phabricator.services.mozilla.com/D192217 ``` You will simply edit your commit message by using `git commit --amend` to add that bottom line, pointing it to the URL of the revision that has all of the review feedback ([D192217](https://phabricator.services.mozilla.com/D192217)), then re-submit with moz-phab. For future reference, you could have added this bottom line before submitting the first time, and it would have updated that revision instead of creating a new one. The only difference right now is that we have to abandon this new one as well. I don't expect you to have known how to do this, though, so no worries there! --- Once you get these newest changes into the correct revision, I've got some review feedback for you. Thank you for your work on this!