Bug 1819554 Comment 1 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
I think opening the popup itself can't be made to wait very easily, but I was using `gBrowser.tabLocalization.formatMessagesSync` for something recently. Looks like there is already a [sync Localization instance](https://searchfox.org/mozilla-central/rev/dcf64fc565e3749119bd57202e2ab06533155d16/browser/base/content/tabbrowser.js#49-54) with all the strings loaded, so maybe the simplest solution is to just use that for tooltips. It looks like that's what the subtitles use for the tab sound UI?
Revision 1 by
on 
I think opening the popup itself can't be made to wait very easily, but I was using `gBrowser.tabLocalization.formatMessagesSync` for something recently. Looks like there is already a [sync Localization instance](https://searchfox.org/mozilla-central/rev/dcf64fc565e3749119bd57202e2ab06533155d16/browser/base/content/tabbrowser.js#49-54) with all the strings loaded, so maybe the simplest solution is to just use that for tooltips. It looks like that's what the subtitles use for the tab sound UI?

Edit: Actually `gBrowser.getTabTooltip` is already using it. Maybe this method could just be merged into createTooltip since it's the only caller, and just simplify all this so there's only one call to the Localization instance
Revision 2 by
on 
I think opening the popup itself can't be made to wait very easily, but I was using `gBrowser.tabLocalization.formatMessagesSync` for something recently. Looks like there is already a [sync Localization instance](https://searchfox.org/mozilla-central/rev/dcf64fc565e3749119bd57202e2ab06533155d16/browser/base/content/tabbrowser.js#49-54) with all the strings loaded, so maybe the simplest solution is to just use that for tooltips. It looks like that's what the subtitles use for the tab sound UI?

Edit: Actually `gBrowser.getTabTooltip` is already using it. ~Maybe this method could just be merged into createTooltip since it's the only caller, and just simplify all this so there's only one call to the Localization instance~ It's not the only caller :(

Back to Bug 1819554 Comment 1