(In reply to Sam Foster [:sfoster] (he/him) from comment #4) > I don't have strong opinions on who implements it, it just seemed orthogonal to the rest of the changes and something we could work on independently, and would increase the scope and risk of this bug significantly if they remained bundled together. My plan is to implement this part first - listing recently closed tabs from all windows. It seems a clean split? This part will work with or without the other. And 1820660 can be worked on with or without this - as we already expose recently closed tabs and windows elsewhere. Sure, but we are changing the recently closed tabs API behavior at the session store level for this bug, not just in Firefox View (but the string changes are just for Firefox View). But yeah, to minimize risk and having a large patch it makes sense to separate them. I'll pick that bug up and we can coordinate landing them.
Bug 1819675 Comment 5 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to Sam Foster [:sfoster] (he/him) from comment #4) > I don't have strong opinions on who implements it, it just seemed orthogonal to the rest of the changes and something we could work on independently, and would increase the scope and risk of this bug significantly if they remained bundled together. My plan is to implement this part first - listing recently closed tabs from all windows. It seems a clean split? This part will work with or without the other. And 1820660 can be worked on with or without this - as we already expose recently closed tabs and windows elsewhere. Sure, but we are changing the recently closed tabs API behavior at the session store level for this bug, not just in Firefox View (but the string changes are just for Firefox View). You probably want to adjust the story points for this bug though, since it was sized to account for this change. But yeah, to minimize risk and avoid having a large patch it makes sense to separate them. I'll pick that bug up and we can coordinate landing them.
(In reply to Sam Foster [:sfoster] (he/him) from comment #4) > I don't have strong opinions on who implements it, it just seemed orthogonal to the rest of the changes and something we could work on independently, and would increase the scope and risk of this bug significantly if they remained bundled together. My plan is to implement this part first - listing recently closed tabs from all windows. It seems a clean split? This part will work with or without the other. And 1820660 can be worked on with or without this - as we already expose recently closed tabs and windows elsewhere. Sure, but we are changing the recently closed tabs API behavior at the session store level for this bug, not just in Firefox View (but the string changes are just for Firefox View). You probably want to adjust the story points for this bug though, unless you think it should still be an 8 - it was sized with the persistence change in mind. But yeah, to minimize risk and avoid having a large patch it makes sense to separate them. I'll pick that bug up and we can coordinate landing them.