### Beta/Release Uplift Approval Request * **User impact if declined**: To be clear, users won't be impacted if this request is declined. The problem is that changes in other services (bedrock and stubattribution) are currently blocked until all builds support this new `dlsource` key. If we were to land/deploy those changes in the two services, the result would be that no attribution data would be collected in Telemetry. This is because Firefox drops all attribution data when an unsupported key is found, see Bug 1824130. * **Is this code covered by automated tests?**: Yes * **Has the fix been verified in Nightly?**: Yes * **Needs manual test from QE?**: Yes * **If yes, steps to reproduce**: - Download a Firefox build - Install Firefox - Open `about:telemetry` and make sure that `dlsource=mozillaci` is present in the environment data * **List of other uplifts needed**: None * **Risk to taking this patch**: Low * **Why is the change risky/not risky? (and alternatives if risky)**: It is allowing a new attribution key. * **String changes made/needed**: * **Is Android affected?**: No
Bug 1819997 Comment 8 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
### Beta/Release Uplift Approval Request * **User impact if declined**: To be clear, users won't be impacted if this request is declined. The problem is that changes in other services (bedrock and stubattribution) are currently blocked until all builds support this new `dlsource` key. If we were to land/deploy those changes in the two services, the result would be that no attribution data would be collected in Telemetry. This is because Firefox drops all attribution data when an unsupported key is found, see Bug 1824130. * **Is this code covered by automated tests?**: Yes * **Has the fix been verified in Nightly?**: Yes * **Needs manual test from QE?**: No * **If yes, steps to reproduce**: * **List of other uplifts needed**: None * **Risk to taking this patch**: Low * **Why is the change risky/not risky? (and alternatives if risky)**: It is allowing a new attribution key. * **String changes made/needed**: * **Is Android affected?**: No Edit: QE no longer required