I'm glad I checked the Try run. :) It looks like we do have some test-related cleanup to do. We've got a test failure for exposing `ContentVisibilityAutoStateChangeEvent` as a property on `window` (which I think is expected/intentional -- at least, `window.ContentVisibilityAutoStateChangeEvent` is indeed defined in Chrome -- so we probably just need to update the test expectations): https://treeherder.mozilla.org/logviewer?job_id=407655619&repo=try&lineNumber=7902 ...and a related failure about that same event being unrecognized by a test: `dom/events/test/test_all_synthetic_events.html | Unknown event found: ContentVisibilityAutoStateChangeEvent`: https://treeherder.mozilla.org/logviewer?job_id=407655385&repo=try&lineNumber=2560 (I'm guessing both of those^ just require us to update an allow-list with the new event name.) We also have some failures in layout/style/test: https://treeherder.mozilla.org/logviewer?job_id=407655492&repo=try&lineNumber=6881 (I think these are pointing at the fact that we have `invisible` as a value in property_database.js, but in fact the name of the keyword is `hidden`: https://searchfox.org/mozilla-central/rev/ed1ebe7bc313eaaec1ed9c2a761fa0fc53e85210/layout/style/test/property_database.js#12972 https://searchfox.org/mozilla-central/rev/ed1ebe7bc313eaaec1ed9c2a761fa0fc53e85210/servo/components/style/values/specified/box.rs#1441-1451 ) And also a WPT failure in one WPT, and an unexpected-pass in another (both of which use `content-visibility` but are outside of the `content-visibility` test directory, so they weren't getting the pref enabled): `Unexpected fail: css/css-overflow/overflow-clip-margin-007.html` https://treeherder.mozilla.org/logviewer?job_id=407655358&repo=try&lineNumber=23474 `Unexpected pass: html/editing/the-hidden-attribute/hidden-ua-stylesheet.html` https://treeherder.mozilla.org/logviewer?job_id=407655419&repo=try&lineNumber=14252 (That unexpected pass is also accompanied by an earlier `WARNING: YOU ARE LEAKING THE WORLD (at least one JSRuntime and everything alive inside it, that is) AT JS_ShutDown TIME. FIX THIS!`. That also sounds bad, though I don't know for sure if it's associated with this pref enabling vs. background noise in the log that only got surfaced by the fact that we had other failures there.)
Bug 1820058 Comment 3 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
I'm glad I checked the Try run. :) It looks like we do have some test-related cleanup to do. We've got a test failure for exposing `ContentVisibilityAutoStateChangeEvent` as a property on `window` (which I think is expected/intentional -- at least, `window.ContentVisibilityAutoStateChangeEvent` is indeed defined in Chrome -- so we probably just need to update the test expectations): https://treeherder.mozilla.org/logviewer?job_id=407655619&repo=try&lineNumber=7902 ...and a related failure about that same event being unrecognized by a test: `dom/events/test/test_all_synthetic_events.html | Unknown event found: ContentVisibilityAutoStateChangeEvent`: https://treeherder.mozilla.org/logviewer?job_id=407655385&repo=try&lineNumber=2560 (I'm guessing both of those^ just require us to update an allow-list with the new event name.) We also have some failures in layout/style/test: https://treeherder.mozilla.org/logviewer?job_id=407655492&repo=try&lineNumber=6881 (I think these are pointing at the fact that we have `invisible` as a value in property_database.js, but in fact the name of the keyword is `hidden`: https://searchfox.org/mozilla-central/rev/ed1ebe7bc313eaaec1ed9c2a761fa0fc53e85210/layout/style/test/property_database.js#12972 https://searchfox.org/mozilla-central/rev/ed1ebe7bc313eaaec1ed9c2a761fa0fc53e85210/servo/components/style/values/specified/box.rs#1441-1451 ) And also a WPT failure in one WPT, and an unexpected-pass in another (both of which use `content-visibility` but are outside of the `content-visibility` test directory, so they weren't getting the pref enabled): `Unexpected fail: css/css-overflow/overflow-clip-margin-007.html` https://treeherder.mozilla.org/logviewer?job_id=407655358&repo=try&lineNumber=23474 `Unexpected pass: html/editing/the-hidden-attribute/hidden-ua-stylesheet.html` https://treeherder.mozilla.org/logviewer?job_id=407655419&repo=try&lineNumber=14252 (That unexpected pass is also accompanied by an earlier `WARNING: YOU ARE LEAKING THE WORLD (at least one JSRuntime and everything alive inside it, that is) AT JS_ShutDown TIME. FIX THIS!`. That also sounds bad, though I don't know for sure if it's associated with this pref enabling vs. background noise in the log that only got surfaced by the fact that we had other failures there, vs. a random coincidence with an unrelated leak cropping up in the same task.)