Bug 1820241 Comment 16 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Alas, there is no JS side to FOG (at least not yet). Due to (IIRC) needing to have a wildcard named getter the `Glean` and `GleanPings` globals are implemented [in](https://searchfox.org/mozilla-central/rev/d2786d9a6af7507bc3443023f0495b36b7e84c2d/toolkit/components/glean/bindings/Glean.cpp#63) [C++](https://searchfox.org/mozilla-central/rev/d2786d9a6af7507bc3443023f0495b36b7e84c2d/toolkit/components/glean/bindings/GleanPings.cpp#57). I'm not sure if pulling JS-known information like `AppConstants` can be done and is advisable to do from C++?

We do have some XPCOM in `nsIFOG`... I could try putting the `MOZ_ARTIFACT_BUILDS` knowledge in a JS-implemented method on the FOG global?

Speaking of `MOZ_ARTIFACT_BUILDS`, I couldn't find docs on it but [I gather](https://searchfox.org/mozilla-central/source/build/moz.configure/init.configure#446-452) it's the build-time define we should be using [instead of `COMPILE_ENVIRONMENT`](https://searchfox.org/mozilla-central/source/toolkit/components/glean/docs/dev/preferences.md#83) to identify we're in the "build" step of an artifact build? If so, I think I should file a follow-up to move away from `COMPILE_ENVIRONMENT`.
Revision 1 by
on 
Alas, there is no JS side to FOG (at least not yet). Due to (IIRC) needing to have a wildcard named getter the `Glean` and `GleanPings` globals are implemented [in](https://searchfox.org/mozilla-central/rev/d2786d9a6af7507bc3443023f0495b36b7e84c2d/toolkit/components/glean/bindings/Glean.cpp#63) [C++](https://searchfox.org/mozilla-central/rev/d2786d9a6af7507bc3443023f0495b36b7e84c2d/toolkit/components/glean/bindings/GleanPings.cpp#57). I'm not sure if pulling JS-known information like `AppConstants` can be done and is advisable to do from C++?

We do have some XPCOM in `nsIFOG`... I could try putting the `MOZ_ARTIFACT_BUILDS` knowledge in a JS-implemented method on the FOG service?

Speaking of `MOZ_ARTIFACT_BUILDS`, I couldn't find docs on it but [I gather](https://searchfox.org/mozilla-central/source/build/moz.configure/init.configure#446-452) it's the build-time define we should be using [instead of `COMPILE_ENVIRONMENT`](https://searchfox.org/mozilla-central/source/toolkit/components/glean/docs/dev/preferences.md#83) to identify we're in the "build" step of an artifact build? If so, I think I should file a follow-up to move away from `COMPILE_ENVIRONMENT`.

Back to Bug 1820241 Comment 16