Bugzilla

(In reply to Walter K. from comment #12)
> (In reply to Sarah Clements [:sclements] from comment #11)
> > Created attachment 9335257 [details]
> > Bug 1820660 - Recently closed tabs persist between sessions for 7 days r=Gijs,dao,sfoster
> > 
> > 
> > * Recently closed tabs will no longer be truncated to whatever max_undo_tabs prefs is set to, instead closed tabs will
> > be filtered for recency (max 7 days old), during SessionStore.initSession.
> > 
> > * Add marionette tests for the above two scenarios, and fix test bustages due to these changes.
> 
> Stop. This is actually breaking *Recently Closed Tabs.* While fixing lost cross-session tab history is needed, arbitrary trimming tab history after 7 days is illogical and random. Within content of History, "recent" means "last".
> 
> This will lead to new bugs being filled by people not knowing why items from the list are getting inexplicably lost. Keep ``sessionstore.max_tabs_undo`` pref, leave logical and consistent *Recently Closed Tabs* be.  If wanted, this new tabs history feature you are creating should be explicitly called *Tabs from the last 7 days* or similar, not *Recently Closed Tabs*. Why me going on vacation for a week should lead to loosing all recent tabs? 
> 
> If Firefox View wants to display tabs from the last 7 days, it should be a separate feature there.

First of all, your comment is quite rude - I understand you have concerns about this change but please remember you are speaking to people who are dedicated to working on this full time and thought and planning has gone into this. See comment 2 for why this change regarding last 7 days is being implemented, however I'm sure our UX team will take your feedback into account.

Currently recently closed tabs is saved in SessionStore based on whatever the `max_tabs_undo` pref is set to - the default being 25 tabs - and so this change also accommodates plans to show more recently closed tabs in future features than just the last 25.

(In reply to Walter K. from comment #12)
> (In reply to Sarah Clements [:sclements] from comment #11)
> > Created attachment 9335257 [details]
> > Bug 1820660 - Recently closed tabs persist between sessions for 7 days r=Gijs,dao,sfoster
> > 
> > 
> > * Recently closed tabs will no longer be truncated to whatever max_undo_tabs prefs is set to, instead closed tabs will
> > be filtered for recency (max 7 days old), during SessionStore.initSession.
> > 
> > * Add marionette tests for the above two scenarios, and fix test bustages due to these changes.
> 
> Stop. This is actually breaking *Recently Closed Tabs.* While fixing lost cross-session tab history is needed, arbitrary trimming tab history after 7 days is illogical and random. Within content of History, "recent" means "last".
> 
> This will lead to new bugs being filled by people not knowing why items from the list are getting inexplicably lost. Keep ``sessionstore.max_tabs_undo`` pref, leave logical and consistent *Recently Closed Tabs* be.  If wanted, this new tabs history feature you are creating should be explicitly called *Tabs from the last 7 days* or similar, not *Recently Closed Tabs*. Why me going on vacation for a week should lead to loosing all recent tabs? 
> 
> If Firefox View wants to display tabs from the last 7 days, it should be a separate feature there.

First of all, your comment is quite rude - I understand you have concerns about this change but please remember you are speaking to people who are dedicated to working on this full time and thought and planning has gone into this. See comment 2 for why this change regarding last 7 days is being implemented, however I'm sure our UX team will take your feedback into account. Additionally, this initial implementation puts the 7 days value behind a pref - this was mostly for testing-related reasons but it obviously then gives users some level of customization.

Currently recently closed tabs is saved in SessionStore based on whatever the `max_tabs_undo` pref is set to - the default being 25 tabs - and so this change also accommodates plans to show more recently closed tabs in future features than just the last 25.