(In reply to Jens Stutte [:jstutte] from comment #3) > (In reply to Christian Holler (:decoder) from comment #0) > > There are some occurrences though where a `cp` is aquired and used without a null check where the origin of the `cp` looks different, so I am not touching that for now. Help/advice appreciated if these places should also be refactored or need null checks. > > Can you provide pointers to those you'd like to be helped with? Thanks! One location I found immediately is https://searchfox.org/mozilla-central/rev/416f31a51174620f04fc994d248b664b54517699/dom/ipc/ContentParent.cpp#7685-7701
Bug 1821002 Comment 5 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to Jens Stutte [:jstutte] from comment #3) > (In reply to Christian Holler (:decoder) from comment #0) > > There are some occurrences though where a `cp` is aquired and used without a null check where the origin of the `cp` looks different, so I am not touching that for now. Help/advice appreciated if these places should also be refactored or need null checks. > > Can you provide pointers to those you'd like to be helped with? Thanks! One location I found immediately is https://searchfox.org/mozilla-central/rev/416f31a51174620f04fc994d248b664b54517699/dom/ipc/ContentParent.cpp#7685-7701 I rechecked the others and the few I could find already check `cp` anyway, so we don't need to refactor.