Bug 1823391 Comment 5 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Jon Coppeard (:jonco) from comment #4)
> This patch conflicts with another recent change.
> 
> Jens, is this crash still happening?  And if so is there a test case to reproduce it?

It [happens sometimes in the wild, it seems, yes](https://crash-stats.mozilla.org/search/?moz_crash_reason=ScriptLoader&product=Firefox&date=%3E%3D2023-02-28T09%3A57%3A00.000Z&date=%3C2023-05-30T09%3A57%3A00.000Z&_facets=signature&_facets=moz_crash_reason&_sort=-date&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#crash-reports). It is probably early to say if there are still cases after that recent change (I would assume it to be unrelated). And if the worker ref has no callback at all, we must be very sure that there are other mechanics that will remove it always when the worker goes away.
(In reply to Jon Coppeard (:jonco) from comment #4)
> This patch conflicts with another recent change.
> 
> Jens, is this crash still happening?  And if so is there a test case to reproduce it?

It [happens sometimes in the wild, it seems, yes](https://crash-stats.mozilla.org/search/?moz_crash_reason=ScriptLoader&product=Firefox&date=%3E%3D2023-02-28T09%3A57%3A00.000Z&date=%3C2023-05-30T09%3A57%3A00.000Z&_facets=signature&_facets=moz_crash_reason&_sort=-date&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#crash-reports). It is probably early to say if there are still cases after that recent change (I would assume it to be unrelated). And if the worker ref has no callback at all, we must be very sure that there are other mechanics that will remove it always when the worker goes away. I am not aware of a testcase.

Back to Bug 1823391 Comment 5