Bug 1826453 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Currently, the metrics for reporting tab page clicks lives in `TabLayoutObserver.onTabSelected`, which is an artifact for specifically handling tabs in an XML TabLayout. These metrics should instead be refactored to a middleware as a side effect from `TabsTrayAction.PageSelected` fired in `TabsTrayController.handleTrayScrollingToPosition`
Revision 1 by
on 
Currently, the metrics for reporting tab page clicks lives in `TabLayoutObserver.onTabSelected`, which is an artifact for specifically handling tabs in an XML TabLayout. These metrics should instead be refactored to a middleware as a side effect from `TabsTrayAction.PageSelected` fired in `TabsTrayController.handleTrayScrollingToPosition` OR directly into `TabsTrayController.handleTrayScrollingToPosition`, pending how much effort it is to stand up a brand new middleware just for telemetry.

Back to Bug 1826453 Comment 0