Humm... yeah that's a good point. So you think the Spotlight is attempting to open immediately but it's just being delayed until the prompt is closed? That would explain why the message is still showing even though Firefox is now the default browser. Like, the targeting was evaluated while the prompt was still open, before Firefox was set to default. And it was just the actual opening of the SubDialog that was delayed until the prompt was closed. Since it's an async prompt, I would have expected that if you try to open a dialog while the prompt is open, it would just fizzle and do nothing. I figured the "queueing" behavior of prompts was just a consequence of prompt 1 spinning the event loop until closed. But if I'm mistaken then that would explain the behavior... But either way, it seems like one easy fix would be to just `await DefaultBrowserCheck.prompt(win)`. The whole thing is happening in an idle task so I don't think that would cause any problems with startup. It may be a moot point if we end up removing these messages or converting them into ASRouter messages. That might take us a while to make a decision though
Bug 1827441 Comment 6 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Humm... yeah that's a good point. So you think the Spotlight is attempting to open immediately but it's just being delayed until the prompt is closed? That would explain why the message is still showing even though Firefox is now the default browser. Like, the targeting was evaluated while the prompt was still open, before Firefox was set to default. And it was just the actual opening of the SubDialog that was delayed until the prompt was closed. Since it's an async prompt, I would have expected that if you try to open a dialog while the prompt is open, it would just fizzle and do nothing. I figured the "queueing" behavior of prompts was just a consequence of (synchronous) prompt 1 spinning the event loop until closed. But if I'm mistaken then that would explain the behavior... But either way, it seems like one easy fix would be to just `await DefaultBrowserCheck.prompt(win)`. The whole thing is happening in an idle task so I don't think that would cause any problems with startup. It may be a moot point if we end up removing these messages or converting them into ASRouter messages. That might take us a while to make a decision though