Bug 1828741 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
We should try using the newly created `moz-label` element in `panel-list`. The `panel-list` element currently has some logic to create a XUL label when possible in order to get accesskey underlining support: https://searchfox.org/mozilla-central/source/toolkit/content/widgets/panel-list.js#519-523

Since we now have an HTML label that provides this same underlining it's worth seeing if that can be cleaned up. Also worth determining if we will still need the `#setLabelContents` [logic](https://searchfox.org/mozilla-central/source/toolkit/content/widgets/panel-list.js#603-608) after making this change.
Revision 1 by
on 
We should try using the newly created `moz-label` element in `panel-list`. The `panel-list` element currently has some logic to create a XUL label when possible in order to get accesskey underlining support: https://searchfox.org/mozilla-central/source/toolkit/content/widgets/panel-list.js#519-523

Since we now have an HTML label that provides this same underlining it's worth seeing if that can be cleaned up. Also worth determining if we will still need the `#setLabelContents` [logic](https://searchfox.org/mozilla-central/rev/d1e731d931b7b46237175de1701849a7cf5c8579/toolkit/content/widgets/panel-list/panel-list.js#760) after making this change.
Revision 2 by
on 
We should try using the newly created `moz-label` element in `panel-list`. The `panel-list` element currently has some logic to create a XUL label when possible in order to get accesskey underlining support: https://searchfox.org/mozilla-central/source/toolkit/content/widgets/panel-list.js#519-523

Since we now have an HTML label that provides this same underlining it's worth seeing if that can be cleaned up. Also worth determining if we will still need the `#setLabelContents` [logic](https://searchfox.org/mozilla-central/rev/d1e731d931b7b46237175de1701849a7cf5c8579/toolkit/content/widgets/panel-list/panel-list.js#661-665) after making this change.

Back to Bug 1828741 Comment 0