Bug 1833161 Comment 3 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

The m-c patch doesn't apply cleanly due to bug 1832474, which doesn't need to be uplifted.

Approval Request Comment
[Feature/Bug causing the regression]: Firefox Suggest weather suggestions

[User impact if declined]: This bug is necessary for the Firefox Suggest weather suggestion feature we intend to ship in 114.

[Is this code covered by automated tests?]: Yes

[Has the fix been verified in Nightly?]: No

[Needs manual test from QE? If yes, steps to reproduce]: Yes, should be clear from comment 0

[List of other uplifts needed for the feature/fix]: None

[Is the change risky?]: Low risk

[Why is the change risky/not risky?]: The patch affects only the Suggest weather suggestion, which is disabled by default. Has tests.

[String changes made/needed]: None
The m-c patch doesn't apply cleanly due to conflicting changes in the test in bug 1832474, which doesn't need to be uplifted.

Approval Request Comment
[Feature/Bug causing the regression]: Firefox Suggest weather suggestions

[User impact if declined]: This bug is necessary for the Firefox Suggest weather suggestion feature we intend to ship in 114.

[Is this code covered by automated tests?]: Yes

[Has the fix been verified in Nightly?]: No

[Needs manual test from QE? If yes, steps to reproduce]: Yes, should be clear from comment 0

[List of other uplifts needed for the feature/fix]: None

[Is the change risky?]: Low risk

[Why is the change risky/not risky?]: The patch affects only the Suggest weather suggestion, which is disabled by default. Has tests.

[String changes made/needed]: None

Back to Bug 1833161 Comment 3