Bug 1835742 Comment 1 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Ultimately, the change I'm proposing is pretty simple:

```diff
diff --git a/browser/components/newtab/lib/ASRouterTargeting.jsm b/browser/components/newtab/lib/ASRouterTargeting.jsm
index 54f05c1cb8ef3..8d9fa4af73338 100644
--- a/browser/components/newtab/lib/ASRouterTargeting.jsm
+++ b/browser/components/newtab/lib/ASRouterTargeting.jsm
@@ -254,7 +254,7 @@ function CheckBrowserNeedsUpdate(
       );
       let result = await check.result;
       if (!result.succeeded) {
-        throw result.request;
+        return false;
       }
       checker._value = !!result.updates.length;
       return checker._value;
```
Revision 1 by
on 
Ultimately, the change I'm proposing is pretty simple:

```diff
diff --git a/browser/components/newtab/lib/ASRouterTargeting.jsm b/browser/components/newtab/lib/ASRouterTargeting.jsm
index 54f05c1cb8ef3..8d9fa4af73338 100644
--- a/browser/components/newtab/lib/ASRouterTargeting.jsm
+++ b/browser/components/newtab/lib/ASRouterTargeting.jsm
@@ -254,7 +254,7 @@ function CheckBrowserNeedsUpdate(
       );
       let result = await check.result;
       if (!result.succeeded) {
-        throw result.request;
+        return false;
       }
       checker._value = !!result.updates.length;
       return checker._value;
```

Edit: could also do this without losing the console message
```diff
-        throw result.request;
+        lazy.ASRouterPreferences.console.error(
+          "CheckBrowserNeedsUpdate failed :>> ",
+          result.request
+        );
+        return false;
```

Back to Bug 1835742 Comment 1