Recap of the plan: - this bug's scope finishes with removing any direct usage of `NS_QuickSort` from central. In doing so it uses a conservative default for arrays of elements that are not trivially copy assignable and adds some paranoia debug code. - Bug 1842130 wants to introduce better/faster handling for the special case of `nsTArray<RefPtr<T>>` - Bug 1842134 collects the remaining improvements for other arrays of elements that are not trivially copy assignable - Bug 1839052 will remove the dead code of `NS_QuickSort` once it's really dead - Bug 1842136 shall provide some explainer on when and how to use which sorting variants - We may want to have another bug to remove the most paranoia debug code from `nsTArray::Sort` and/or switch from warnings to (static?) asserts.
Bug 1839051 Comment 19 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Recap of the plan: - this bug's scope finishes with removing any direct usage of `NS_QuickSort` from central. In doing so it uses a conservative default for `nsTArray`s of elements that are not trivially copy assignable and adds some paranoia debug code. - Bug 1842130 wants to introduce better/faster handling for the special case of `nsTArray<RefPtr<T>>` - Bug 1842134 collects the remaining improvements for other arrays of elements that are not trivially copy assignable - Bug 1839052 will remove the dead code of `NS_QuickSort` once it's really dead - Bug 1842136 shall provide some explainer on when and how to use which sorting variants - We may want to have another bug to remove the most paranoia debug code from `nsTArray::Sort` and/or switch from warnings to (static?) asserts.
Recap of the plan: - this bug's scope finishes with removing any direct usage of `NS_QuickSort` from central. In doing so it uses a conservative default for `nsTArray`s of elements that are not trivially copy assignable and adds some paranoia debug code. - Bug 1842130 wants to introduce better/faster handling for the special case of `nsTArray<RefPtr<T>>`. We probably do not want to land this bug until we have that, too. - Bug 1842134 collects the remaining improvements for other arrays of elements that are not trivially copy assignable. Those can be worked out one by one as they come in. - Bug 1839052 will remove the dead code of `NS_QuickSort` once it's really dead - Bug 1842136 shall provide some explainer on when and how to use which sorting variants - We may want to have another bug to remove the most paranoia debug code from `nsTArray::Sort` and/or switch from warnings to (static?) asserts once we verified all existing uses.
Recap of the plan: - this bug's scope finishes with removing any direct usage of `NS_QuickSort` from central. In doing so it uses a conservative default for `nsTArray`s of elements that are not trivially copy assignable and adds some paranoia debug code. - Bug 1842130 wants to introduce better/faster handling for the special case of `nsTArray<RefPtr<T>>`. We probably do not want to land this bug until we have that, too. - Bug 1842134 collects the remaining improvements for other arrays of elements that are not trivially copy assignable. Those can be worked out one by one as they come in. - Bug 1839052 will remove the dead code of `NS_QuickSort` once it's really dead. - Bug 1842136 shall provide some explainer on when and how to use which sorting variants. - We may want to have another bug to remove the most paranoia debug code from `nsTArray::Sort` and/or switch from warnings to (static?) asserts once we verified all existing uses.