Bug 1840137 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
nsHttpChannel.cpp/h file contains lot of non-member classes/static functions defined within it. For better readability we should consider such classes outside of nsHttpChannel.cpp/h.

Some examples of such classes/functions are:

1. [Class AutoRedirectVetoNotifier](https://searchfox.org/mozilla-central/source/netwerk/protocol/http/nsHttpChannel.cpp#265)
2. [GetSTSConsoleErrorTag()](https://searchfox.org/mozilla-central/source/netwerk/protocol/http/nsHttpChannel.cpp#1847)
3. [IsSubRangeRequest()](https://searchfox.org/mozilla-central/source/netwerk/protocol/http/nsHttpChannel.cpp#3499)
4.[DoUpdateExpirationTime](https://searchfox.org/mozilla-central/source/netwerk/protocol/http/nsHttpChannel.cpp#4283)
5.[DoAddCacheEntryHeaders](https://searchfox.org/mozilla-central/source/netwerk/protocol/http/nsHttpChannel.cpp#4843)
6.[GetAuthType](https://searchfox.org/mozilla-central/source/netwerk/protocol/http/nsHttpChannel.cpp#4949)
7.[StoreAuthorizationMetaData](https://searchfox.org/mozilla-central/source/netwerk/protocol/http/nsHttpChannel.cpp#4960)
Revision 1 by
on 
nsHttpChannel.cpp/h file contains lot of non-member classes/static functions defined within it. For better readability we should consider such classes outside of nsHttpChannel.cpp/h.

Some examples of such classes/functions are:

1. [Class AutoRedirectVetoNotifier](https://searchfox.org/mozilla-central/source/netwerk/protocol/http/nsHttpChannel.cpp#265)

2. [GetSTSConsoleErrorTag()](https://searchfox.org/mozilla-central/source/netwerk/protocol/http/nsHttpChannel.cpp#1847)

3. [IsSubRangeRequest](https://searchfox.org/mozilla-central/source/netwerk/protocol/http/nsHttpChannel.cpp#3499)

4. [DoUpdateExpirationTime](https://searchfox.org/mozilla-central/source/netwerk/protocol/http/nsHttpChannel.cpp#4283)

5. [DoAddCacheEntryHeaders](https://searchfox.org/mozilla-central/source/netwerk/protocol/http/nsHttpChannel.cpp#4843)

6. [GetAuthType](https://searchfox.org/mozilla-central/source/netwerk/protocol/http/nsHttpChannel.cpp#4949)

7. [StoreAuthorizationMetaData](https://searchfox.org/mozilla-central/source/netwerk/protocol/http/nsHttpChannel.cpp#4960)

Back to Bug 1840137 Comment 0