Bug 1841374 Comment 11 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to :Gijs (he/him) from comment #9)
> This focuses the "Got it" button, and for me, only that gets read by NVDA.

Thanks for testing. Same for me, NVDA.

> (In reply to Anna Yeddi [:ayeddi] from comment #4)
> > I finally was able to get the callout on my Windows machine with NVDA running and, if it is clicked, NVDA would announce it and all the accessibility properties are rendered good. The issue, IMO, is that the container of the callout has `role=alert` but no accessible name (which could be `aria-labelledby` to the ID of the title of the callout)
> 
> I don't see an element with this role but perhaps I'm not looking in the right place; I'm not familiar with the internal structure of the callout.

Yeah as you noted, the inner content container's role is currently [alertdialog](https://searchfox.org/mozilla-central/rev/48e7e2c55bd0d8977ff4f581a3753bcfc4259b83/browser/components/aboutwelcome/content-src/components/MultiStageProtonScreen.jsx#507), unless otherwise configured.

A couple years ago, we used to set `role=alert` on the outermost container. This was when we used `<div>` rather than `<panel>` for the container, and callouts were exclusively in-content. This was removed later in bug 1790382.
(In reply to :Gijs (he/him) from comment #9)
> This focuses the "Got it" button, and for me, only that gets read by NVDA.

Thanks for testing. Same for me, NVDA.

> (In reply to Anna Yeddi [:ayeddi] from comment #4)
> > I finally was able to get the callout on my Windows machine with NVDA running and, if it is clicked, NVDA would announce it and all the accessibility properties are rendered good. The issue, IMO, is that the container of the callout has `role=alert` but no accessible name (which could be `aria-labelledby` to the ID of the title of the callout)
> 
> I don't see an element with this role but perhaps I'm not looking in the right place; I'm not familiar with the internal structure of the callout.

Yeah as you noted, the inner content container's role is currently [alertdialog](https://searchfox.org/mozilla-central/rev/48e7e2c55bd0d8977ff4f581a3753bcfc4259b83/browser/components/aboutwelcome/content-src/components/MultiStageProtonScreen.jsx#507), unless otherwise configured.

A couple years ago, we used to set `role=alert` on the outermost container. This was when we used `<div>` rather than `<panel>` for the container, and callouts were exclusively in-content. This was added in bug 1781088, and removed in bug 1790382.

Back to Bug 1841374 Comment 11