Given the volume on ESR it sounds worth having proper bucketing indeed. However, the patch from bug 1860767 should result in proper bucketing as well, and it is simpler and makes more sense. It removes unnecessary use of DbgHelp in shipped builds, whereas the patch I wrote here just prevents bad things from happening when unnecessary use occurs. So, I would rather recommend uplifting the patch from bug 1860767 than this one.
Bug 1843354 Comment 14 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Given the volume on ESR it sounds worth having proper bucketing indeed. However, the patch from bug 1860767 should result in proper bucketing as well, and it is simpler and makes more sense. It removes unnecessary use of DbgHelp in shipped builds, whereas the patch I wrote here just prevents bad things from happening when unnecessary use occurs. So, I would rather recommend taking the patch from bug 1860767 than this one.
Given the volume on ESR it sounds worth having proper bucketing indeed. However, the patch from bug 1860767 should result in proper bucketing as well, and it is simpler and makes more sense. It removes unnecessary use of DbgHelp in shipped builds, whereas the patch I wrote here just prevents bad things from happening when/if unnecessary use occurs. So, I would rather recommend taking the patch from bug 1860767 than this one.