Bug 1845340 Comment 16 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Jared Hirsch [:jhirsch] (he/him) (Needinfo please) from comment #15)
> > I think that'd be reasonable. Would you like to do the honours, or do you want me to take this back? :-)
> 
> Sure, I can update the patch. I'll move the `test_out_of_process_use` test to its own file, so that I can use the browser.toml skip-if to conditionally disable it on Android but run it on other platforms, and I'll file a followup bug to get it working on Android.

Thank you!

> > So this is an Android bug where we ship about:certificate on Android, but don't ship everything it needs (the toolkit + common styling). It should probably be filed as a separate follow-up bug: either we shouldn't ship about:certificate on android (obvious question: is there any way to load that on Android today?) or we should make it not depend on things that are not available, or we should make whatever it needs available on Android.
> 
> I'm able to load about:certificate in the emulator, so I guess this must be a test setup bug.

Sure, outside of automation / test running, it won't crash. But I bet the CSS file still isn't loading... and so the styling might look wonky if you were to open `about:certificate` with an actual cert. This is also what happens to some network error pages, cf. bug 1810039 and some of the bugs in the "see also".
(In reply to Jared Hirsch [:jhirsch] (he/him) (Needinfo please) from comment #15)
> > I think that'd be reasonable. Would you like to do the honours, or do you want me to take this back? :-)
> 
> Sure, I can update the patch. I'll move the `test_out_of_process_use` test to its own file, so that I can use the browser.toml skip-if to conditionally disable it on Android but run it on other platforms, and I'll file a followup bug to get it working on Android.

Thank you!

> > So this is an Android bug where we ship about:certificate on Android, but don't ship everything it needs (the toolkit + common styling). It should probably be filed as a separate follow-up bug: either we shouldn't ship about:certificate on android (obvious question: is there any way to load that on Android today?) or we should make it not depend on things that are not available, or we should make whatever it needs available on Android.
> 
> I'm able to load about:certificate in the emulator, so I guess this must be a test setup bug.

Sure, outside of automation / test running, it won't crash. But I bet the CSS file still isn't loading... and so the styling might look wonky if you were to open `about:certificate` with an actual cert. This is also what happens to some network error pages, cf. bug 1810039 and some of the bugs in the "see also".

Edit: to be explicit about this, https://searchfox.org/mozilla-central/rev/64ddb621a0d3905fc2e3df475517d4163d377b22/toolkit/themes/shared/desktop-jar.inc.mn#59 and https://searchfox.org/mozilla-central/search?q=common.css&path=jar&regexp=false make it fairly straightforward to know the file just isn't packaged at all on Android (irrespective of fenix vs. xpcshell or w/e).

Back to Bug 1845340 Comment 16