Bug 1845442 Comment 6 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Molly Howell (she/her) [:mhowell] from comment #3)
> Mike, do you know if we have something in this migrator that could have cached Chrome profile paths, or some other way we could have gotten into a time-of-check vs. time-of-use issue here? Otherwise I'm not sure how this would have happened.

Sounds like the Local State file, which we grab [here](https://searchfox.org/mozilla-central/rev/d81e60336d9f498ad3985491dc17c2b77969ade4/browser/components/migration/ChromeMigrationUtils.sys.mjs#234-238) claims this profile exists, but it does not, in fact, actually exist?

I'm actually inclined to suggest that this is the expected behaviour. The only brokenness is the fact that we report errors - but in fact, this _is_ an error state. We shouldn't normally end up in the situation where the `Local State` file claims the profile exist, but it is actually missing on disk.

I'll mark this as S4 for now and ask Mike to confirm as WORKSFORME/INVALID when he's back from PTO. :-)
(In reply to Molly Howell (she/her) [:mhowell] from comment #3)
> Mike, do you know if we have something in this migrator that could have cached Chrome profile paths, or some other way we could have gotten into a time-of-check vs. time-of-use issue here? Otherwise I'm not sure how this would have happened.

Sounds like the Local State file, which we grab [here](https://searchfox.org/mozilla-central/rev/d81e60336d9f498ad3985491dc17c2b77969ade4/browser/components/migration/ChromeMigrationUtils.sys.mjs#234-238) claims this profile exists, but it does not, in fact, actually exist?

I'm actually inclined to suggest that this is the expected behaviour. The only brokenness is the fact that we report errors in devtools (not directly to the user) - but in fact, this _is_ an error state. We shouldn't normally end up in the situation where the `Local State` file claims the profile exist, but it is actually missing on disk.

I'll mark this as S4 for now and ask Mike to confirm as WORKSFORME/INVALID when he's back from PTO. :-)

Back to Bug 1845442 Comment 6