Bug 1845737 Comment 10 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Emilio Cobos Álvarez (:emilio) from comment #5)
> FWIW given that description, I think the main issue is that your patch allows to create a `DocumentL10n` that will effectively never hit the ready state. I suspect you basically need [this chunk of code](https://searchfox.org/mozilla-central/rev/d6576544301cacc0e393fbc919c53e4e6b0d46ec/dom/base/Document.cpp#4395-4398) on the lazy getter too (or shuffle things around a little bit).

I haven't yet checked but I would have thought that because my patch was still creating a link (like the JS version), the code there would have run anyway? But thanks for the hint, I'll dig into this...
(In reply to Emilio Cobos Álvarez (:emilio) from comment #5)
> FWIW given that description, I think the main issue is that your patch allows to create a `DocumentL10n` that will effectively never hit the ready state. I suspect you basically need [this chunk of code](https://searchfox.org/mozilla-central/rev/d6576544301cacc0e393fbc919c53e4e6b0d46ec/dom/base/Document.cpp#4395-4398) on the lazy getter too (or shuffle things around a little bit).

I haven't yet checked but I would have thought that because my patch was still creating a link (like the JS version), the code there would have run anyway in response to the FTL being added as a `link`? But thanks for the hint, I'll dig into this...

Back to Bug 1845737 Comment 10