(In reply to Jens Stutte [:jstutte] from comment #9) > (In reply to Jens Stutte [:jstutte] from comment #8) > > I threw this together, but a first smoke test seems to indicate it has bad side effects. This needs more time than I currently have, probably. Joshua, would you mind taking this over? > > I suspect we have too many checks for `AppShutdownConfirmed`in our code that might better be `AppShutdown`. The patch was based on confusing "quit-application-granted" with "quit-application". Joshua will continue investigation.
Bug 1845778 Comment 10 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to Jens Stutte [:jstutte] from comment #9) > (In reply to Jens Stutte [:jstutte] from comment #8) > > I threw this together, but a first smoke test seems to indicate it has bad side effects. This needs more time than I currently have, probably. Joshua, would you mind taking this over? > > I suspect we have too many checks for `AppShutdownConfirmed`in our code that might better be `AppShutdown`. The patch was based on confusing "quit-application-granted" with "quit-application". But the last statement might still be true, especially together with the weirdness that we have a shutdown barrier [`quitApplicationGranted`](https://searchfox.org/mozilla-central/rev/8f09f6a6ff0d8b6ea75a1e1279a06ba02479578c/toolkit/components/asyncshutdown/nsIAsyncShutdown.idl#202) but apparently not for `quitApplication`. Joshua will continue investigation.
(In reply to Jens Stutte [:jstutte] from comment #9) > I suspect we have too many checks for `AppShutdownConfirmed`in our code that might better be `AppShutdown`. The patch was based on confusing "quit-application-granted" with "quit-application". But the last statement might still be true, especially together with the weirdness that we have a shutdown barrier [`quitApplicationGranted`](https://searchfox.org/mozilla-central/rev/8f09f6a6ff0d8b6ea75a1e1279a06ba02479578c/toolkit/components/asyncshutdown/nsIAsyncShutdown.idl#202) but apparently not for `quitApplication`. Joshua will continue investigation.