We'll want to record things like: 0. OHTTP gateway config fetching success/failure 1. HTTP status codes for outer (OHTTP) requests and inner requests (maybe OHTTP succeeds but the eventual server of the actual response returns errors). 2. bogus responses from the server (ie 200 OK but the JSON isn't valid, doesn't match schema, or other issues with its content) 3. timeouts 4. request cancellations because the user navigated before we got a response for the product + recommendation/ad requests. We may want some of these for the image request as well. Given that the other data collection for this project is using Glean, I guess we should use Glean here, too. The data needs for this bug should be the same for Desktop and Android. Based on this, I think we should be using a toolkit/components/shopping/ metrics yaml file that ends up in `gecko_metrics`. But the existing yaml file there only records desktop data relating to the desktop nimbus and onboarding work, and is in `firefox_desktop_metrics`. I'm not sure how best to resolve this - I thought we could just move the existing toolkit metrics file to the `browser/components/shopping` directory and add a different one in the original toolkit location that *does* get put in `gecko_metrics`, but conversation on slack suggests that maybe this isn't the best solution. :chutten, can you help?
Bug 1848386 Comment 0 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
We'll want to record things like: 0. OHTTP gateway config fetching success/failure 1. HTTP status codes for outer (OHTTP) requests and inner requests (maybe OHTTP succeeds but the eventual server of the actual response returns errors). 2. bogus responses from the server (ie 200 OK but the JSON isn't valid, doesn't match schema, or other issues with its content) 3. timeouts 4. request cancellations because the user navigated before we got a response for the product + recommendation/ad requests. We may want some of these for the image request as well. Given that the other data collection for this project is using Glean, I guess we should use Glean here, too. The data needs for this bug should be the same for Desktop and Android. Based on this, I think we should be using a toolkit/components/shopping/ metrics yaml file that ends up in `gecko_metrics`. But the existing yaml file there only records desktop data relating to the desktop nimbus and onboarding work, and is in `firefox_desktop_metrics`. I'm not sure how best to resolve this - I thought we could just move the existing toolkit metrics file to the `browser/components/shopping` directory (as the probes are only recorded to from `browser/` code anyway) and add a different one in the original toolkit location that *does* get put in `gecko_metrics`, but conversation on slack suggests that maybe this isn't the best solution. :chutten, can you help?