Bug 1848829 Comment 6 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

It's a string pref that doesn't have a default value specified in StaticPrefList.yaml or prefs.js, so it is determined that it needs to be sanitized.

We get the pref here

https://searchfox.org/mozilla-central/rev/146638366864f73ee8a697ea76480eb02c00eb3c/dom/canvas/ClientWebGLContext.cpp#2269

and in both place where we use it we check another pref called StaticPrefs::webgl_sanitize_unmasked_renderer

https://searchfox.org/mozilla-central/rev/146638366864f73ee8a697ea76480eb02c00eb3c/dom/canvas/ClientWebGLContext.cpp#2299
https://searchfox.org/mozilla-central/rev/146638366864f73ee8a697ea76480eb02c00eb3c/dom/canvas/ClientWebGLContext.cpp#2335

so it seems that this pref has already been considered to be sanitized when necessary. Do we just add it to the sDynamicPrefOverrideList allow list?
It's a string pref that doesn't have the default value specified in StaticPrefList.yaml or prefs.js, so it is determined that it needs to be sanitized.

We get the pref here

https://searchfox.org/mozilla-central/rev/146638366864f73ee8a697ea76480eb02c00eb3c/dom/canvas/ClientWebGLContext.cpp#2269

and in both place where we use it we check another pref called StaticPrefs::webgl_sanitize_unmasked_renderer

https://searchfox.org/mozilla-central/rev/146638366864f73ee8a697ea76480eb02c00eb3c/dom/canvas/ClientWebGLContext.cpp#2299
https://searchfox.org/mozilla-central/rev/146638366864f73ee8a697ea76480eb02c00eb3c/dom/canvas/ClientWebGLContext.cpp#2335

so it seems that this pref has already been considered to be sanitized when necessary. Do we just add it to the sDynamicPrefOverrideList allow list?

Back to Bug 1848829 Comment 6