Bug 1848848 Comment 1 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Thank you for working on it, Amy!

To clarify the expected behavior for after this bug (what is not yet working is marked inline):

1. Keyboard alone:
1.1. User can `Tab` to the `Show more` button and the button has a visible outline when focused with a keyboard
1.2. User can press `Enter` or `Space` to activate the `Show more` - the button's visual label changes to `Show less`
1.3. *[To be fixed] After the new content is shown and the button is changed to `Show less`, the programmatic focus is moved to the last visible highlight (this element could have `tabindex="-1"` so it won't be added to the focus order but would be focusable with `.focus()` JS method).*
1.4. *[To be fixed] User can press `Tab` to move the focus to `Show less` button*
1.5. If the user presses `Enter` or `Space` on the `Show less` button, some content is hidden, the button's label is changed to `Show more`, and the focus stays on that button (and the focus outline is still visible)

2. Screen reader (examples of key shortcuts would be provided for NVDA on Windows):
2.1. User can press `Down arrow` from anywhere (i.e. from the `X` Close button on the sidebar) and get to hear `Snippets from recent reviews` and its content
2.2. After pressing `Down arrow` a couple of times, the user hears the last visible (on-screen) text highlight snippet being announced
2.3. *[To be fixed] User presses `Down arrow` once again and they hear `Show more, button` (aka they do not hear any text that is not visible on the screen)*
2.4. If user presses `Enter` or `Space` while on the `Show more` button, the button's visual label changes to `Show less`
2.5. *[To be fixed] After the new content is shown and the button is changed to `Show less`, the focus is moved to the last visible highlight and the screen reader user hears the announcement of that highlight.*
2.6. A user presses `Down arrow` and hears the next highlight being announced (this highlight was previously hidden)
2.7. A user can press `Down arrow` a few more times to hear the rest of the visible highlights
2.8. From the last highlight, the user presses `Down arrow` once again and they hear `Show less, button` 
2.9. If the user presses `Enter` or `Space` on the `Show less` button, the button's label is changed to `Show more`, and the focus stays on that button - the user hears `Show more, button`
2.10. *[To be fixed] If the user presses `Up arrow` from `Show more` button, they would hear the last visible highlight (the last on the screen, not the one that is not visible)*

LMK if you have any questions
Thank you for working on it, Amy!

To clarify the expected behavior for after this bug (what is not yet working is marked inline):

1. Keyboard alone:
1.1. User can `Tab` to the `Show more` button and the button has a visible outline when focused with a keyboard
1.2. User can press `Enter` or `Space` to activate the `Show more` - the button's visual label changes to `Show less`
1.3. **[To be fixed] After the new content is shown and the button is changed to `Show less`, the programmatic focus is moved to the last visible highlight (this element could have `tabindex="-1"` so it won't be added to the focus order but would be focusable with `.focus()` JS method).**
1.4. **[To be fixed] User can press `Tab` to move the focus to `Show less` button**
1.5. If the user presses `Enter` or `Space` on the `Show less` button, some content is hidden, the button's label is changed to `Show more`, and the focus stays on that button (and the focus outline is still visible)

2. Screen reader (examples of key shortcuts would be provided for NVDA on Windows):
2.1. User can press `Down arrow` from anywhere (i.e. from the `X` Close button on the sidebar) and get to hear `Snippets from recent reviews` and its content
2.2. After pressing `Down arrow` a couple of times, the user hears the last visible (on-screen) text highlight snippet being announced
2.3. **[To be fixed] User presses `Down arrow` once again and they hear `Show more, button` (aka they do not hear any text that is not visible on the screen)**
2.4. If user presses `Enter` or `Space` while on the `Show more` button, the button's visual label changes to `Show less`
2.5. **[To be fixed] After the new content is shown and the button is changed to `Show less`, the focus is moved to the last visible highlight and the screen reader user hears the announcement of that highlight.**
2.6. A user presses `Down arrow` and hears the next highlight being announced (this highlight was previously hidden)
2.7. A user can press `Down arrow` a few more times to hear the rest of the visible highlights
2.8. From the last highlight, the user presses `Down arrow` once again and they hear `Show less, button` 
2.9. If the user presses `Enter` or `Space` on the `Show less` button, the button's label is changed to `Show more`, and the focus stays on that button - the user hears `Show more, button`
2.10. **[To be fixed] If the user presses `Up arrow` from `Show more` button, they would hear the last visible highlight (the last on the screen, not the one that is not visible)**

LMK if you have any questions

Back to Bug 1848848 Comment 1