Bug 1851236 Comment 4 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

This is one case which is totally unrealistic in sp3. Web pages don't in general create their own events (nor do they dispatch many events).
But sure, we should optimize this.

I wonder if codegenerator should use nsAutoString for dictionaries, that would at least help with the alloc/free.
Or even faster would be some way more complicated setup where bindings layer would pass JSString value when available to the dictionary and only if JSString wasn't passed, but some other type, then conversion would happen (I think that would be still working per webidl spec).
This is one case which is totally unrealistic in sp3. Web pages don't in general create their own events (nor do they dispatch many events).
But sure, we should optimize this.

I wonder if codegenerator should use nsAutoString for dictionaries, that would at least help with the alloc/free.
Or even faster would be some way more complicated setup where bindings layer would pass JSString value when available to the dictionary and only if JSString wasn't passed, but some other type, then conversion would happen (I think that would be still working per webidl spec).

Also, should KeyboardEvents have ProbablyShortLivingWrapper annotation? With the current nursery GC scheduling it might actually regress performance, if we end up running minor GC even more during tests.
This is one case which is totally unrealistic in sp3. Web pages don't in general create their own events (nor do they dispatch many events).
But sure, we should optimize this.

I wonder if codegenerator should use nsAutoString for dictionaries, that would at least help with the alloc/free.
Or even faster would be some way more complicated setup where bindings layer would pass JSString value when available to the dictionary and only if JSString wasn't passed, but some other type, then conversion would happen (I think that would be still working per webidl spec).

Back to Bug 1851236 Comment 4