Bug 1852157 Comment 2 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to :Gijs (away until Sept 18th; he/him) from comment #1)
> (In reply to Perry McManis [:perry.mcmanis] from comment #0)
> > Currently the shopping sidebar displayed events would be sent many more times than desired. This is due to a complication in the way the sidebar render is done.
> 
> Can you elaborate? I'm not sure I understand the concern / problem involved.

Sure,

so currently when you navigate to a page and the sidebar is displayed, by sending an event in `render()` it is very noisy. You will get several events when really, we should only get a single one.

this patch is the correct one: https://phabricator.services.mozilla.com/D186500

I am currently investigating moving this to `onLocationChange()` as I see that now takes `aFlags` and I should be able to pick a combination that works.
(In reply to :Gijs (away until Sept 18th; he/him) from comment #1)
> (In reply to Perry McManis [:perry.mcmanis] from comment #0)
> > Currently the shopping sidebar displayed events would be sent many more times than desired. This is due to a complication in the way the sidebar render is done.
> 
> Can you elaborate? I'm not sure I understand the concern / problem involved.

Sure,

so currently when you navigate to a page and the sidebar is displayed, by sending an event in `render()` it is very noisy. You will get several events when really, we should only get a single one.

this patch is the correct one: https://phabricator.services.mozilla.com/D186500

that shows how I currently have it set up.

I am currently investigating moving this to `onLocationChange()` as I see that now takes `aFlags` and I should be able to pick a combination that works.

Back to Bug 1852157 Comment 2