### Beta/Release Uplift Approval Request * **User impact if declined**: Crashes, maybe some weird behavior. * **Is this code covered by automated tests?**: Yes * **Has the fix been verified in Nightly?**: Yes * **Needs manual test from QE?**: No * **If yes, steps to reproduce**: * **List of other uplifts needed**: None * **Risk to taking this patch**: Medium * **Why is the change risky/not risky? (and alternatives if risky)**: The risk is low to medium just because this is complicated code and I guess I wouldn't be horribly surprised if it revealed some other problem. But: it only kicks in for unusual circumstances, the current behavior is clearly wrong, and the updated behavior is removing things from consideration when they get weird, resulting in less overall weirdness. While I appreciate weirdness in the wider world, I prefer to avoid it in Firefox's behavior. * **String changes made/needed**: none * **Is Android affected?**: Yes
Bug 1852729 Comment 10 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
### Beta/Release Uplift Approval Request * **User impact if declined**: Crashes, maybe some weird behavior. Possibly security problems, though I haven't come up with a scenario. * **Is this code covered by automated tests?**: Yes * **Has the fix been verified in Nightly?**: Yes * **Needs manual test from QE?**: No * **If yes, steps to reproduce**: * **List of other uplifts needed**: None * **Risk to taking this patch**: Medium * **Why is the change risky/not risky? (and alternatives if risky)**: The risk is low to medium just because this is complicated code and I guess I wouldn't be horribly surprised if it revealed some other problem. But: it only kicks in for unusual circumstances, the current behavior is clearly wrong, and the updated behavior is removing things from consideration when they get weird, resulting in less overall weirdness. While I appreciate weirdness in the wider world, I prefer to avoid it in Firefox's behavior. * **String changes made/needed**: none * **Is Android affected?**: Yes