Bug 1853044 Comment 9 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Based on the gif, the selection should be cleared when the input string changes, and that doesn't happen.

I think I could reproduce the bug, by ensuring that is what happens.
Basically match some url, shift+left to select its end, type something else and press Enter BEFORE the results change.

I suspect this is a regression of Bug 1816572, because we probably clear the selection when new results arrive.
We should clear the view selection earlier if possible.
Based on the gif, the selection should be cleared when the input string changes, and that doesn't happen.

I think I could reproduce the bug, by ensuring that condition happens.
Basically match some url, shift+left to select its end, type something else and press Enter BEFORE the results change.

I suspect this is a regression of Bug 1816572, because we probably clear the selection when new results arrive.
We should clear the view selection earlier if possible.
Based on the gif, the selection should be cleared when the input string changes, and that doesn't happen.

I think I could reproduce the bug, by ensuring that condition happens.
Basically match some url, shift+left to select its end, type something else and press Enter BEFORE the results change.

I suspect this is a regression of Bug 1816572, because we probably clear the selection when new results arrive.
We should clear the view selection earlier if possible, or ignore the selection if it doesn't match the current search string.
Based on the gif, the selection should be cleared when the input string changes, and that doesn't happen.

I think I could reproduce the bug, by ensuring that condition happens.
Basically match some url, shift+left to select its end, type something else and press Enter BEFORE the results change.

I suspect this is a regression of Bug 1816572, because we probably clear the selection when new results arrive.
We should clear the view selection earlier if possible, or ignore the selection if it doesn't match the current search string.
I'ts also strange Enter is handled before the selection is cleared, as input happened so the urlbar event bufferer should await for results and delay the confirmation.
Needs some debug.

Back to Bug 1853044 Comment 9