Bugzilla

Hi marifer,

Thank you for your patches! 

One thing we do a bit differently here at Mozilla, compared to a flow that you may be more used to on GitHub, for example, is that each "commit" should effectively be a self-contained, functional change of code. 

For example, if you are fixing an eslint error, you wouldn't add on a new commit to that. You would make the changes and amend them into your single commit, and then re-publish that commit, almost as though you were force-pushing to GitHub. 

The nice thing about Phabricator is that it keeps track of the changes between each "version" of the commit. 

So what you should do is go into your WIP patches on Phabricator, scroll all the way to the bottom, and add an action in the dropdown to abandon that revision. 

Next, locally, you'll want to pop your WIP commits off of your WIP stack and amend them (or use fixup, etc.) to then have a single commit. 

At that point, you would use moz-phab to update the single revision. 

Let me know if you have any questions, and thank you!

Hi marifer,

Thank you for your patches! 

One thing we do a bit differently here at Mozilla, compared to a flow that you may be more used to on GitHub, for example, is that each "commit" should effectively be a self-contained, functional change of code. 

For example, if you are fixing an eslint error, you wouldn't add on a new commit for just that. You would make the changes and amend them into your single commit, and then re-publish that commit, almost as though you were force-pushing to GitHub. 

The nice thing about Phabricator is that it keeps track of the changes between each "version" of the commit. 

So what you should do is go into your WIP patches on Phabricator, scroll all the way to the bottom, and add an action in the dropdown to abandon that revision. 

Next, locally, you'll want to pop your WIP commits off of your WIP stack and amend them (or use fixup, etc.) to then have a single commit. 

At that point, you would use moz-phab to update the single revision. 

Let me know if you have any questions, and thank you!