Bugzilla

(In reply to Malte Jürgens [:mjurgens] from comment #1)
> This seems to affect HTTPS-First and HTTPS-Only in general as well, I could reproduce the same issue with both. Navigations which are upgraded also seem to suffer from the same issue.

True, but I think from a privacy/security perception point of view there's a difference between clicking on a link and seeing in history it was http, VS typing a schemeless origin in the address bar and find Firefox has apparently tried the http version.
As a user I would think Firefox is visiting http first, and then the page redirected.

(In reply to Masatoshi Kimura [:emk] from comment #2)
> If we do not add http versions to global history, when we click a http link, the link color will not turn to the visited color. 

That should indeed not change. Most upgrades are fine as-is, because the user has actually clicked on an http link, it's ok to show that in history.
The perception problem here is specific to the address bar use-case.

The frecency problem should be solved absolutely, a simple workaround could be to not mark as "typed" these schemeless visits, so the http version doesn't generate a large score... it's not a perfect solution though because any "upgraded" visit should ideally always generate a low score, but that requires the Docshell to pass AddURIVisit some flag that tells "this has been upgraded", and afaik we know only later if the upgrade was successful. We need a timeline of the upgrade and the docshell calls to visit addition to tell what can be done.

The perception problem is maybe not super critical, but I think it's worth checking how we can make it less confusing.

(In reply to Malte Jürgens [:mjurgens] from comment #1)
> This seems to affect HTTPS-First and HTTPS-Only in general as well, I could reproduce the same issue with both. Navigations which are upgraded also seem to suffer from the same issue.

True, but I think from a privacy/security perception point of view there's a difference between clicking on a link and seeing in history it was http, VS typing a schemeless origin in the address bar and find Firefox has apparently tried the http version.
As a user I would think Firefox is visiting http first, and then the page redirected.

(In reply to Masatoshi Kimura [:emk] from comment #2)
> If we do not add http versions to global history, when we click a http link, the link color will not turn to the visited color. 

That should indeed not change. Most upgrades are fine as-is, because the user has actually clicked on an http link, it's ok to show that in history.
The perception problem here is specific to the address bar use-case. (I'd be ok with hiding these visits visually, if we'd have the info at hand)

The frecency problem should be solved absolutely, a simple workaround could be to not mark as "typed" these schemeless visits, so the http version doesn't generate a large score... it's not a perfect solution though because any "upgraded" visit should ideally always generate a low score, but that requires the Docshell to pass AddURIVisit some flag that tells "this has been upgraded", and afaik we know only later if the upgrade was successful. We need a timeline of the upgrade and the docshell calls to visit addition to tell what can be done.

The perception problem is maybe not super critical, but I think it's worth checking how we can make it less confusing.

(In reply to Malte Jürgens [:mjurgens] from comment #1)
> This seems to affect HTTPS-First and HTTPS-Only in general as well, I could reproduce the same issue with both. Navigations which are upgraded also seem to suffer from the same issue.

True, but I think from a privacy/security perception point of view there's a difference between clicking on a link and seeing in history it was http, VS typing a schemeless origin in the address bar and find Firefox has apparently tried the http version.
As a user I would think Firefox is visiting http first, and then the page redirected.

(In reply to Masatoshi Kimura [:emk] from comment #2)
> If we do not add http versions to global history, when we click a http link, the link color will not turn to the visited color. 

That should indeed not change. Most upgrades are fine as-is, because the user has actually clicked on an http link, it's ok to show that in history (I'd be ok with hiding these visits visually, if we'd have the info at hand).
The perception problem here is specific to the address bar use-case. 

The frecency problem should be solved absolutely, a simple workaround could be to not mark as "typed" these schemeless visits, so the http version doesn't generate a large score... it's not a perfect solution though because any "upgraded" visit should ideally always generate a low score, but that requires the Docshell to pass AddURIVisit some flag that tells "this has been upgraded", and afaik we know only later if the upgrade was successful. We need a timeline of the upgrade and the docshell calls to visit addition to tell what can be done.

The perception problem is maybe not super critical, but I think it's worth checking how we can make it less confusing.