(In reply to nbulous from comment #4) > I think we need to re-implement attribution based labels because we realized that the "Import from previous browser" string was a copy paste error in our figma files that we didn't intentional test. I believe "Import from [browser name]" is what's in production for most cases. Just wanted to clarify, I don't think "Import from previous browser" was a copy paste error. It's possible to still see "Import from previous browser" if a [user agent is not provided](https://searchfox.org/mozilla-central/source/browser/components/aboutwelcome/modules/AboutWelcomeDefaults.jsm#854), that's the string we fallback to. However, I believe we added the fluent strings for easy setup in this [patch](https://phabricator.services.mozilla.com/D169091) 11 months ago which uses ["Import from previous browser"](https://searchfox.org/mozilla-central/source/browser/locales/en-US/browser/newtab/onboarding.ftl#190) in all cases for easy setup rather than [re-purposing the user agent strings](https://searchfox.org/mozilla-central/source/browser/components/aboutwelcome/modules/AboutWelcomeDefaults.jsm#854) which uses ["Import from ${previousBrowser}"](https://searchfox.org/mozilla-central/source/browser/locales/en-US/browser/newtab/onboarding.ftl#52). Based off [Ed's comment](https://bugzilla.mozilla.org/show_bug.cgi?id=1858985#c2) this may have been an intentional decision given that migration wizard could show a different browser on the subsequent screen. Let me know what you think!
Bug 1858985 Comment 5 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to nbulous from comment #4) > I think we need to re-implement attribution based labels because we realized that the "Import from previous browser" string was a copy paste error in our figma files that we didn't intentional test. I believe "Import from [browser name]" is what's in production for most cases. Just wanted to clarify, I don't think "Import from previous browser" was a copy paste error. It's possible to still see "Import from previous browser" if a [user agent is not provided](https://searchfox.org/mozilla-central/source/browser/components/aboutwelcome/modules/AboutWelcomeDefaults.jsm#854), that's the string we fallback to. However, I believe we added the fluent strings for easy setup in this [patch](https://phabricator.services.mozilla.com/D169091) 11 months ago which uses ["Import from previous browser"](https://searchfox.org/mozilla-central/source/browser/locales/en-US/browser/newtab/onboarding.ftl#190) in all cases for easy setup rather than [re-purposing the user agent strings](https://searchfox.org/mozilla-central/source/browser/components/aboutwelcome/modules/AboutWelcomeDefaults.jsm#854) which uses ["Import from ${previousBrowser}"](https://searchfox.org/mozilla-central/source/browser/locales/en-US/browser/newtab/onboarding.ftl#52). Based off [Ed's comment](https://bugzilla.mozilla.org/show_bug.cgi?id=1858985#c2) this may have been an intentional decision given that migration wizard could show a different browser on the subsequent screen. I'm not sure if I was a part of this discussion so I may be missing some context in that regard. Let me know what you think, happy to proceed with either option!
(In reply to nbulous from comment #4) > I think we need to re-implement attribution based labels because we realized that the "Import from previous browser" string was a copy paste error in our figma files that we didn't intentional test. I believe "Import from [browser name]" is what's in production for most cases. Just wanted to clarify, I don't think "Import from previous browser" was a copy paste error. It's possible to still see "Import from previous browser" if a [user agent is not provided](https://searchfox.org/mozilla-central/source/browser/components/aboutwelcome/modules/AboutWelcomeDefaults.jsm#854), that's the string we fallback to. However, I believe we added the fluent strings for easy setup in this [patch](https://phabricator.services.mozilla.com/D169091) 11 months ago which uses ["Import from previous browser"](https://searchfox.org/mozilla-central/source/browser/locales/en-US/browser/newtab/onboarding.ftl#190) in all cases for easy setup rather than [re-purposing the user agent strings](https://searchfox.org/mozilla-central/source/browser/components/aboutwelcome/modules/AboutWelcomeDefaults.jsm#854) which uses ["Import from ${previousBrowser}"](https://searchfox.org/mozilla-central/source/browser/locales/en-US/browser/newtab/onboarding.ftl#52). Based off [Ed's comment](https://bugzilla.mozilla.org/show_bug.cgi?id=1858985#c2) this may have been an intentional decision given that migration wizard could show a different browser on the subsequent screen. I'm not sure if I was a part of this discussion so I may be missing some context in that regard. Let me know what you think!
(In reply to nbulous from comment #4) > I think we need to re-implement attribution based labels because we realized that the "Import from previous browser" string was a copy paste error in our figma files that we didn't intentional test. I believe "Import from [browser name]" is what's in production for most cases. Just wanted to clarify, I don't think "Import from previous browser" was a copy paste error. It's possible to still see "Import from previous browser" if a [user agent is not provided](https://searchfox.org/mozilla-central/source/browser/components/aboutwelcome/modules/AboutWelcomeDefaults.jsm#854), that's the string we fallback to. However, I believe we added the fluent strings for easy setup in this [patch](https://phabricator.services.mozilla.com/D169091) 11 months ago which uses ["Import from previous browser"](https://searchfox.org/mozilla-central/source/browser/locales/en-US/browser/newtab/onboarding.ftl#190) in all cases for easy setup rather than [re-purposing the user agent strings](https://searchfox.org/mozilla-central/source/browser/components/aboutwelcome/modules/AboutWelcomeDefaults.jsm#854) which uses ["Import from ${previousBrowser}"](https://searchfox.org/mozilla-central/source/browser/locales/en-US/browser/newtab/onboarding.ftl#52) if a user agent is found. Based off [Ed's comment](https://bugzilla.mozilla.org/show_bug.cgi?id=1858985#c2) this may have been an intentional decision given that migration wizard could show a different browser on the subsequent screen. I'm not sure if I was a part of this discussion so I may be missing some context in that regard. Let me know what you think!