For QA: This is a fairly large refactor of most things related to private browsing mode. I thought it might make it easier on your end to be able to do a large smoke test of these changes, rather than address them individually. Hope that was an okay assumption. I tried to make a list of the areas this patch touches. It may not be completely exhaustive. Mode retained across app sessions Mode inherited from a deep link Window is in secure mode while in private mode if setting is enabled PBM button New tabs from long-press on tab counter New tabs from tabs tray Tabs tray opens in correct mode from Home Screen and browser screen Long-press top site to open in PBM Opening tabs from bookmarks Opening tabs from history Opening tabs from history groups Opening recently closed private tab Addons report button and settings open tabs in private mode if app is in private mode Reader mode gets themed differently Recent tabs section visibility and recent bookmarks count metrics not reported in private mode Standard homepage view metric not incremented when in private mode Wallpapers onboarding not shown in private mode Search suggestions not shown in private mode if settings is enabled
Bug 1861459 Comment 1 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
For QA: This is a fairly large refactor of most things related to private browsing mode. I thought it might make it easier on your end to be able to do a large smoke test of these changes, rather than address them individually. Hope that was an okay assumption. I tried to make a list of the areas this patch touches. It may not be completely exhaustive, so it would be great to add anything from existing test suites that relate to private browsing mode. Mode retained across app sessions Mode inherited from a deep link Window is in secure mode while in private mode if setting is enabled PBM button New tabs from long-press on tab counter New tabs from tabs tray Tabs tray opens in correct mode from Home Screen and browser screen Long-press top site to open in PBM Opening tabs from bookmarks Opening tabs from history Opening tabs from history groups Opening recently closed private tab Addons report button and settings open tabs in private mode if app is in private mode Reader mode gets themed differently Recent tabs section visibility and recent bookmarks count metrics not reported in private mode Standard homepage view metric not incremented when in private mode Wallpapers onboarding not shown in private mode Search suggestions not shown in private mode if settings is enabled
For QA: This is a fairly large refactor of most things related to private browsing mode. I thought it might make it easier on your end to be able to do a large smoke test of these changes, rather than address them individually. Hope that was an okay assumption. There should be no change in functionality from what previously existed. I tried to make a list of the areas this patch touches. It may not be completely exhaustive, so it would be great to add anything from existing test suites that relate to private browsing mode. Mode retained across app sessions Mode inherited from a deep link Window is in secure mode while in private mode if setting is enabled PBM button New tabs from long-press on tab counter New tabs from tabs tray Tabs tray opens in correct mode from Home Screen and browser screen Long-press top site to open in PBM Opening tabs from bookmarks Opening tabs from history Opening tabs from history groups Opening recently closed private tab Addons report button and settings open tabs in private mode if app is in private mode Reader mode gets themed differently Recent tabs section visibility and recent bookmarks count metrics not reported in private mode Standard homepage view metric not incremented when in private mode Wallpapers onboarding not shown in private mode Search suggestions not shown in private mode if settings is enabled