We previous have some security issues related JS popups, we have to invest some time checking desktop's implementation and try to bring some of their learnings to AC. Desktop implementation https://searchfox.org/mozilla-central/source/dom/base/PopupBlocker.cpp https://searchfox.org/mozilla-central/source/toolkit/actors/PopupBlockingParent.jsm AC implementation [PromptMiddleware.kt#L40)(https://github.com/mozilla-mobile/android-components/blob/1a9b3eaf58a8a73134926a2ba98141600ae422d3/components/feature/prompts/src/main/java/mozilla/components/feature/prompts/PromptMiddleware.kt#L40) [PromptAbuserDetector](https://github.com/mozilla-mobile/android-components/blob/main/components/feature/prompts/src/main/java/mozilla/components/feature/prompts/dialog/PromptAbuserDetector.kt) Acceptance Criteria: Identify how we can shared the popup blocker between Android and desktop File follow-up tickets to implement them.
Bug 1863383 Comment 0 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
We previous have some security issues related JS popups, we have to invest some time checking desktop's implementation and try to bring some of their learnings to AC. Desktop implementation https://searchfox.org/mozilla-central/source/dom/base/PopupBlocker.cpp https://searchfox.org/mozilla-central/source/toolkit/actors/PopupBlockingParent.jsm AC implementation [PromptMiddleware.kt#L40)(https://github.com/mozilla-mobile/android-components/blob/1a9b3eaf58a8a73134926a2ba98141600ae422d3/components/feature/prompts/src/main/java/mozilla/components/feature/prompts/PromptMiddleware.kt#L40) [PromptAbuserDetector](https://github.com/mozilla-mobile/android-components/blob/main/components/feature/prompts/src/main/java/mozilla/components/feature/prompts/dialog/PromptAbuserDetector.kt) Acceptance Criteria: Identify how we can share the popup blocker between Android and desktop File follow-up tickets to implement them.