Bug 1863629 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

# Lando commit hooks

As part of the hg->git migration we will need to re-implement our Mercurial commit checks in Lando.

## Hooks to port

- Treeclosure hook (see bug 1771695).
- Commit message check (various commit message structure validation checks).
- Prevent NSPR NSS changes (block direct updates to vendored libraries NSPR and NSS).
- Merge day (assert the merge day push doesn't contain unexpected changes).
- Prevent cross-channel messages (block lines with `X-Channel-` in commit message, TBD).
- Check bug references (block commit messages referencing non-public bugs from try).
- Prevent symlinks.
- Prevent WPTSync changes (block changes to files outside of testing/web-platform by the wptsync bot).
- Try task config (block try's `try_task_config.json` from landing outside of try).

## Hooks to convert to Herald rule

- Prevent sync IPC changes (block changes to `sync-messages.init` without IPC peer review).
- Prevent WedIDL changes (block changes to WebIDL files without DOM peer review).

## New checks to add

- Prevent Git submodules.
# Lando commit hooks

As part of the hg->git migration we will need to re-implement our Mercurial commit checks in Lando.

## Hooks to port

- Treeclosure hook (see bug 1771695).
- Commit message check (various commit message structure validation checks).
- Prevent NSPR NSS changes (block direct updates to vendored libraries NSPR and NSS).
- Merge day (assert the merge day push doesn't contain unexpected changes).
- ~~Prevent cross-channel messages (block lines with `X-Channel-` in commit message, TBD).~~ Edit: Can be dropped according to flod.
- Check bug references (block commit messages referencing non-public bugs from try).
- Prevent symlinks.
- Prevent WPTSync changes (block changes to files outside of testing/web-platform by the wptsync bot).
- Try task config (block try's `try_task_config.json` from landing outside of try).

## Hooks to convert to Herald rule

- Prevent sync IPC changes (block changes to `sync-messages.init` without IPC peer review).
- Prevent WedIDL changes (block changes to WebIDL files without DOM peer review).

## New checks to add

- Prevent Git submodules.
# Lando commit hooks

As part of the hg->git migration we will need to re-implement our Mercurial commit checks in Lando.

## Hooks to port

- Treeclosure hook (see bug 1771695).
- Commit message check (various commit message structure validation checks).
- Prevent NSPR NSS changes (block direct updates to vendored libraries NSPR and NSS).
- Merge day (assert the merge day push doesn't contain unexpected changes).
- ~~Prevent cross-channel messages (block lines with `X-Channel-` in commit message, TBD).~~ Edit: Can be dropped according to flod.
- Check bug references (block commit messages referencing non-public bugs from try).
- Prevent symlinks.
- Prevent WPTSync changes (block changes to files outside of testing/web-platform by the wptsync bot).
- Try task config (block try's `try_task_config.json` from landing outside of try).

## Hooks to convert to Herald rule

- ~~Prevent sync IPC changes (block changes to `sync-messages.init` without IPC peer review).~~
- Prevent WedIDL changes (block changes to WebIDL files without DOM peer review).

## New checks to add

- Prevent Git submodules.
# Lando commit hooks

As part of the hg->git migration we will need to re-implement our Mercurial commit checks in Lando.

## Hooks to port

- ~~Treeclosure hook~~ (completed as bug 1771695, migrate all of Treestatus into Lando).
- Commit message check (various commit message structure validation checks).
- Prevent NSPR NSS changes (block direct updates to vendored libraries NSPR and NSS).
- Merge day (assert the merge day push doesn't contain unexpected changes).
- ~~Prevent cross-channel messages (block lines with `X-Channel-` in commit message, TBD).~~ Edit: Can be dropped according to flod.
- Check bug references (block commit messages referencing non-public bugs from try).
- ~~Prevent symlinks~~. (completed as bug 1895762)
- Prevent WPTSync changes (block changes to files outside of testing/web-platform by the wptsync bot).
- Try task config (block try's `try_task_config.json` from landing outside of try).

## Hooks to convert to Herald rule

- ~~Prevent sync IPC changes (block changes to `sync-messages.init` without IPC peer review).~~
- Prevent WedIDL changes (block changes to WebIDL files without DOM peer review).

## New checks to add

- Prevent Git submodules.
# Lando commit hooks

As part of the hg->git migration we will need to re-implement our Mercurial commit checks in Lando.

## Hooks to port

- ~~Treeclosure hook~~ (completed as bug 1771695, migrate all of Treestatus into Lando).
- Commit message check (various commit message structure validation checks).
- Prevent NSPR NSS changes (block direct updates to vendored libraries NSPR and NSS).
- Merge day (assert the merge day push doesn't contain unexpected changes).
- ~~Prevent cross-channel messages (block lines with `X-Channel-` in commit message, TBD).~~ Edit: Can be dropped according to flod.
- Check bug references (block commit messages referencing non-public bugs from try).
- ~~Prevent symlinks~~. (completed as bug 1895762)
- Prevent WPTSync changes (block changes to files outside of testing/web-platform by the wptsync bot).
- ~~Try task config (block try's `try_task_config.json` from landing outside of try)~~ (completed as bug 1895931).

## Hooks to convert to Herald rule

- ~~Prevent sync IPC changes (block changes to `sync-messages.init` without IPC peer review).~~
- Prevent WedIDL changes (block changes to WebIDL files without DOM peer review).

## New checks to add

- Prevent Git submodules.
# Lando commit hooks

As part of the hg->git migration we will need to re-implement our Mercurial commit checks in Lando.

## Hooks to port

- ~~Treeclosure hook~~ (completed as bug 1771695, migrate all of Treestatus into Lando).
- ~~Commit message check (various commit message structure validation checks)~~ (completed as bug 1902545).
- Prevent NSPR NSS changes (block direct updates to vendored libraries NSPR and NSS).
- Merge day (assert the merge day push doesn't contain unexpected changes).
- ~~Prevent cross-channel messages (block lines with `X-Channel-` in commit message, TBD).~~ Edit: Can be dropped according to flod.
- Check bug references (block commit messages referencing non-public bugs from try).
- ~~Prevent symlinks~~. (completed as bug 1895762)
- Prevent WPTSync changes (block changes to files outside of testing/web-platform by the wptsync bot).
- ~~Try task config (block try's `try_task_config.json` from landing outside of try)~~ (completed as bug 1895931).

## Hooks to convert to Herald rule

- ~~Prevent sync IPC changes (block changes to `sync-messages.init` without IPC peer review).~~
- Prevent WedIDL changes (block changes to WebIDL files without DOM peer review).

## New checks to add

- Prevent Git submodules.
# Lando commit hooks

As part of the hg->git migration we will need to re-implement our Mercurial commit checks in Lando.

## Hooks to port

- ~~Treeclosure hook~~ (completed as bug 1771695, migrate all of Treestatus into Lando).
- ~~Commit message check (various commit message structure validation checks)~~ (completed as bug 1902545).
- Prevent NSPR NSS changes (block direct updates to vendored libraries NSPR and NSS).
- Merge day (assert the merge day push doesn't contain unexpected changes).
- ~~Prevent cross-channel messages (block lines with `X-Channel-` in commit message, TBD).~~ Edit: Can be dropped according to flod.
- Check bug references (block commit messages referencing non-public bugs from try).
- ~~Prevent symlinks~~. (completed as bug 1895762)
- Prevent WPTSync changes (block changes to files outside of testing/web-platform by the wptsync bot).
- ~~Try task config (block try's `try_task_config.json` from landing outside of try)~~ (completed as bug 1895931).

## Hooks to convert to Herald rule

- ~~Prevent sync IPC changes (block changes to `sync-messages.init` without IPC peer review).~~
- Prevent WedIDL changes (block changes to WebIDL files without DOM peer review).

## New checks to add

- ~~Prevent Git submodules.~~ (completed as bug 1903462)
# Lando commit hooks

As part of the hg->git migration we will need to re-implement our Mercurial commit checks in Lando.

## Hooks to port

- ~~Treeclosure hook~~ (completed as bug 1771695, migrate all of Treestatus into Lando).
- ~~Commit message check (various commit message structure validation checks)~~ (completed as bug 1902545).
- ~~Prevent NSPR NSS changes (block direct updates to vendored libraries NSPR and NSS).~~ (completed as bug 1903456).
- Merge day (assert the merge day push doesn't contain unexpected changes).
- ~~Prevent cross-channel messages (block lines with `X-Channel-` in commit message, TBD).~~ Edit: Can be dropped according to flod.
- Check bug references (block commit messages referencing non-public bugs from try).
- ~~Prevent symlinks~~. (completed as bug 1895762)
- Prevent WPTSync changes (block changes to files outside of testing/web-platform by the wptsync bot).
- ~~Try task config (block try's `try_task_config.json` from landing outside of try)~~ (completed as bug 1895931).

## Hooks to convert to Herald rule

- ~~Prevent sync IPC changes (block changes to `sync-messages.init` without IPC peer review).~~
- Prevent WedIDL changes (block changes to WebIDL files without DOM peer review).

## New checks to add

- ~~Prevent Git submodules.~~ (completed as bug 1903462)
# Lando commit hooks

As part of the hg->git migration we will need to re-implement our Mercurial commit checks in Lando.

## Hooks to port

- ~~Treeclosure hook~~ (completed as bug 1771695, migrate all of Treestatus into Lando).
- ~~Commit message check (various commit message structure validation checks)~~ (completed as bug 1902545).
- ~~Prevent NSPR NSS changes (block direct updates to vendored libraries NSPR and NSS).~~ (completed as bug 1903456).
- Merge day (assert the merge day push doesn't contain unexpected changes).
- ~~Prevent cross-channel messages (block lines with `X-Channel-` in commit message, TBD).~~ Edit: Can be dropped according to flod.
- Check bug references (block commit messages referencing non-public bugs from try).
- ~~Prevent symlinks~~. (completed as bug 1895762)
- ~~Prevent WPTSync changes (block changes to files outside of testing/web-platform by the wptsync bot).~~ (completed as bug 1903130).
- ~~Try task config (block try's `try_task_config.json` from landing outside of try)~~ (completed as bug 1895931).

## Hooks to convert to Herald rule

- ~~Prevent sync IPC changes (block changes to `sync-messages.init` without IPC peer review).~~
- Prevent WedIDL changes (block changes to WebIDL files without DOM peer review).

## New checks to add

- ~~Prevent Git submodules.~~ (completed as bug 1903462)

Back to Bug 1863629 Comment 0