Bug 1863758 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
full_screen_notification_dialog.xml (Fenix) & dialog_full_screen_notification.xml (Focus) share layouts with the app Snackbar layout. Create a 'Snackbar' style that can be used across these layouts. 

We're essentially duplicating https://searchfox.org/mozilla-mobile/source/firefox-android/fenix/app/src/main/res/layout/fenix_snackbar.xml right now. Since the properties will be common across 2 different XML files, we want to be able to move the common properties into a <style> and be able to call it via style="@style/SnackbarText". 

See https://searchfox.org/mozilla-mobile/source/firefox-android/fenix/app/src/main/res/values/styles.xml#402
Revision 1 by
on 
full_screen_notification_dialog.xml (Fenix) & dialog_full_screen_notification.xml (Focus) share the same properties as the app specific Snackbar layout. Create a 'Snackbar' style that can be used across the app Snackbar layouts. 

> We're essentially duplicating https://searchfox.org/mozilla-mobile/source/firefox-android/fenix/app/src/main/res/layout/fenix_snackbar.xml right now. Since the properties will be common across 2 different XML files, we want to be able to move the common properties into a <style> and be able to call it via style="@style/SnackbarText". 
See https://searchfox.org/mozilla-mobile/source/firefox-android/fenix/app/src/main/res/values/styles.xml#402
Revision 2 by
on 
Original [PR discussion](https://github.com/mozilla-mobile/firefox-android/pull/4394#discussion_r1386827066).

full_screen_notification_dialog.xml (Fenix) & dialog_full_screen_notification.xml (Focus) share the same properties as the app specific Snackbar layout. Create a 'Snackbar' style that can be used across the app Snackbar layouts. 

> We're essentially duplicating https://searchfox.org/mozilla-mobile/source/firefox-android/fenix/app/src/main/res/layout/fenix_snackbar.xml right now. Since the properties will be common across 2 different XML files, we want to be able to move the common properties into a <style> and be able to call it via style="@style/SnackbarText". 
See https://searchfox.org/mozilla-mobile/source/firefox-android/fenix/app/src/main/res/values/styles.xml#402

Back to Bug 1863758 Comment 0