Bugzilla

(In reply to Travis Long [:travis_] from comment #29)
> Comment on attachment 9369649 [details]
> request.md
> 
> # Data Review
> 
> 5) Is the data collection request for default-on or default-off?
> 
> Default-on
> 
Hey Travis. I believe it should be default-off as automatic element click event capturing feature has to be turned on by clients by setting `Configuration.enableAutoElementClickEvents` option to `true`. If they don't set it to `true` explicitly then it is off.

Hey Travis. Thanks a lot for your review.

(In reply to Travis Long [:travis_] from comment #28)
> Thanks for flagging me for data-review Abhishek! I see that this review only covers the non-sensitive context items in the event extras and is listed as Category 2. This is fine, I just wanted to confirm that your plan is still to add the referrer and url to the extras in the next iteration on this, and get the sensitive data review for that data at that time.
> 

You are right. Once the first version lands, we will work on finding out what parts of a page's referrer and url (or something else) will be important to collect for individual products and why. Once we figure that out, we will be in a better position to file the sensitive data collection request (if needed) and update the first version of automatic click events accordingly.

> Just another small suggestion, since the extras are the part here that could contain sensitive information, I would really like to see this information in the data-review request, most appropriately in the description of the event in your response to question 5 of the request form.
> 
> So as to not have to obsolete your current attachment and add a new one, I'll just amend that here to call out the contextual information that is being recorded in the event extras to make it clear that this data review covers just the actual technical context/extras and the addition of any additional extras would require a fresh data-review.
> 

Thanks for doing it. Would it be better if I add a new attachment (making the current one obsolete)? It is a very minimal effort on my side. This way, no one will have to go through all the comments to find the missing important piece of information from data request.


(In reply to Travis Long [:travis_] from comment #29)
> Comment on attachment 9369649 [details]
> request.md
> 
> # Data Review
> 
> 5) Is the data collection request for default-on or default-off?
> 
> Default-on
> 
I believe it should be default-off as automatic element click event capturing feature has to be turned on by clients by setting `Configuration.enableAutoElementClickEvents` option to `true`. If they don't set it to `true` explicitly then it is off.