Bug 1867542 Comment 25 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
(In reply to Sandor Molnar[:smolnar] from comment #24)
> [Failure log -> TEST-UNEXPECTED-FAIL | MediaDataEncoderTest.InvalidSize | Expected: (e0x0) != (nullptr), actual: 0x0 vs (nullptr)](https://treeherder.mozilla.org/logviewer?job_id=439266833&repo=autoland&lineNumber=34689)

From the code, it looks like `AppleEncoderModule::Supports` rejects `0` width or `0` height, so `PEMFactory::FindPEM` and `CreateEncoder` return `null`, so `CreateVideoEncoder`/`CreateH264Encoder` got a `nullptr` and `EXPECT_NE(e0x0, nullptr)` failed.
Revision 1 by
on 
(In reply to Sandor Molnar[:smolnar] from comment #24)
> [Failure log -> TEST-UNEXPECTED-FAIL | MediaDataEncoderTest.InvalidSize | Expected: (e0x0) != (nullptr), actual: 0x0 vs (nullptr)](https://treeherder.mozilla.org/logviewer?job_id=439266833&repo=autoland&lineNumber=34689)

From the code, it looks like `AppleEncoderModule::Supports` rejects `0` width or `0` height, so `PEMFactory::FindPEM` and `CreateEncoder` return `null`, then `CreateVideoEncoder`/`CreateH264Encoder` got a `nullptr` and `EXPECT_NE(e0x0, nullptr)` failed.
Revision 2 by
on 
(In reply to Sandor Molnar[:smolnar] from comment #24)
> [Failure log -> TEST-UNEXPECTED-FAIL | MediaDataEncoderTest.InvalidSize | Expected: (e0x0) != (nullptr), actual: 0x0 vs (nullptr)](https://treeherder.mozilla.org/logviewer?job_id=439266833&repo=autoland&lineNumber=34689)

From the code, it looks like `AppleEncoderModule::Supports` rejects `0` width or `0` height, so `PEMFactory::FindPEM` and `CreateEncoder` return `nullptr`, then `CreateVideoEncoder`/`CreateH264Encoder` got a `nullptr` and `EXPECT_NE(e0x0, nullptr)` failed.

Back to Bug 1867542 Comment 25