Bug 1868380 Comment 14 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Backed out for causing py3 failures on test_yaml_indices.py and also bustages on nsHTTPCompressConv.cpp

* *backout:* https://hg.mozilla.org/integration/autoland/rev/e462210bf1b5ec21b23a8224916b5c8b1895397f
* *push:* https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=8c0e44e4d9ae9b49abf96979e8ee9794ba2e394c
* *failure log:* 
    * [/builds/worker/checkouts/gecko/netwerk/streamconv/converters/nsHTTPCompressConv.cpp:301:8: error: format specifies type 'unsigned long' but the argument has type 'uint64_t' (aka 'unsigned long long') [-Werror,-Wformat]](https://treeherder.mozilla.org/logviewer?job_id=449733994&repo=autoland&lineNumber=80506)
    * [toolkit/components/glean/tests/pytest/test_yaml_indices.py::test_yamls_sorted TEST-UNEXPECTED-FAIL](https://treeherder.mozilla.org/logviewer?job_id=449734018&repo=autoland&lineNumber=226)
Revision 1 by
on 
Backed out for causing py3 failures on test_yaml_indices.py 
* *backout:* https://hg.mozilla.org/integration/autoland/rev/e462210bf1b5ec21b23a8224916b5c8b1895397f
* *push:* https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=8c0e44e4d9ae9b49abf96979e8ee9794ba2e394c
* *failure log:* 
    * [toolkit/components/glean/tests/pytest/test_yaml_indices.py::test_yamls_sorted TEST-UNEXPECTED-FAIL](https://treeherder.mozilla.org/logviewer?job_id=449734018&repo=autoland&lineNumber=226)

```
[task 2024-03-06T10:14:28.071Z] ============================= test session starts ==============================
[task 2024-03-06T10:14:28.071Z] platform linux -- Python 3.8.10, pytest-7.0.1, pluggy-1.4.0 -- /builds/worker/.mozbuild/srcdirs/gecko-8a5b87fe5d69/_virtualenvs/python-test/bin/python
[task 2024-03-06T10:14:28.071Z] rootdir: /builds/worker/checkouts/gecko, configfile: config/mozunit/mozunit/pytest.ini
[task 2024-03-06T10:14:28.074Z] plugins: mock-3.12.0
[task 2024-03-06T10:14:28.074Z] collecting ... collected 1 item
[task 2024-03-06T10:14:28.074Z] 
[task 2024-03-06T10:14:28.074Z] toolkit/components/glean/tests/pytest/test_yaml_indices.py::test_yamls_sorted TEST-UNEXPECTED-FAIL
[task 2024-03-06T10:14:28.074Z] 
[task 2024-03-06T10:14:28.074Z] =================================== FAILURES ===================================
[task 2024-03-06T10:14:28.074Z] ______________________________ test_yamls_sorted _______________________________
[task 2024-03-06T10:14:28.074Z] toolkit/components/glean/tests/pytest/test_yaml_indices.py:36: in test_yamls_sorted
[task 2024-03-06T10:14:28.074Z]     assert (
[task 2024-03-06T10:14:28.074Z] E   AssertionError: gecko_metrics must be be lexicographically sorted.
[task 2024-03-06T10:14:28.074Z] E   assert ['browser/base/content/metrics.yaml',\n 'docshell/base/metrics.yaml',\n 'dom/base/use_counter_metrics.yaml',\n 'dom/media/metrics.yaml',\n 'dom/media/webrtc/metrics.yaml',\n 'dom/metrics.yaml',\n 'dom/performance/metrics.yaml',\n 'dom/security/metrics.yaml',\n 'gfx/metrics.yaml',\n 'image/decoders/metrics.yaml',\n 'js/xpconnect/metrics.yaml',\n 'layout/base/metrics.yaml',\n 'mobile/android/actors/metrics.yaml',\n 'mobile/android/modules/geckoview/metrics.yaml',\n 'netwerk/metrics.yaml',\n 'netwerk/protocol/http/metrics.yaml',\n 'security/manager/ssl/metrics.yaml',\n 'toolkit/components/cookiebanners/metrics.yaml',\n 'toolkit/components/extensions/metrics.yaml',\n 'toolkit/components/formautofill/metrics.yaml',\n 'toolkit/components/glean/metrics.yaml',\n 'toolkit/components/passwordmgr/metrics.yaml',\n 'toolkit/components/pdfjs/metrics.yaml',\n 'toolkit/components/processtools/metrics.yaml',\n 'toolkit/components/reportbrokensite/metrics.yaml',\n 'toolkit/components/resistfingerprinting/metrics.yaml',\n 'toolkit/components/translations/metrics.yaml',\n 'toolkit/mozapps/extensions/metrics.yaml',\n 'toolkit/mozapps/handling/metrics.yaml',\n 'toolkit/xre/metrics.yaml',\n 'xpcom/metrics.yaml'] == ['browser/base/content/metrics.yaml',\n 'docshell/base/metrics.yaml',\n 'dom/base/use_counter_metrics.yaml',\n 'dom/media/metrics.yaml',\n 'dom/media/webrtc/metrics.yaml',\n 'dom/security/metrics.yaml',\n 'dom/metrics.yaml',\n 'dom/performance/metrics.yaml',\n 'gfx/metrics.yaml',\n 'image/decoders/metrics.yaml',\n 'js/xpconnect/metrics.yaml',\n 'layout/base/metrics.yaml',\n 'mobile/android/actors/metrics.yaml',\n 'mobile/android/modules/geckoview/metrics.yaml',\n 'netwerk/metrics.yaml',\n 'netwerk/protocol/http/metrics.yaml',\n 'security/manager/ssl/metrics.yaml',\n 'toolkit/components/cookiebanners/metrics.yaml',\n 'toolkit/components/extensions/metrics.yaml',\n 'toolkit/components/formautofill/metrics.yaml',\n 'toolkit/components/glean/metrics.yaml',\n 'toolkit/components/passwordmgr/metrics.yaml',\n 'toolkit/components/pdfjs/metrics.yaml',\n 'toolkit/components/processtools/metrics.yaml',\n 'toolkit/components/reportbrokensite/metrics.yaml',\n 'toolkit/components/resistfingerprinting/metrics.yaml',\n 'toolkit/components/translations/metrics.yaml',\n 'toolkit/mozapps/extensions/metrics.yaml',\n 'toolkit/mozapps/handling/metrics.yaml',\n 'toolkit/xre/metrics.yaml',\n 'xpcom/metrics.yaml']
[task 2024-03-06T10:14:28.074Z] E     At index 5 diff: 'dom/metrics.yaml' != 'dom/security/metrics.yaml'
[task 2024-03-06T10:14:28.074Z] E     Full diff:
[task 2024-03-06T10:14:28.074Z] E       [
[task 2024-03-06T10:14:28.074Z] E        'browser/base/content/metrics.yaml',
[task 2024-03-06T10:14:28.074Z] E        'docshell/base/metrics.yaml',
[task 2024-03-06T10:14:28.074Z] E        'dom/base/use_counter_metrics.yaml',
[task 2024-03-06T10:14:28.074Z] E        'dom/media/metrics.yaml',
[task 2024-03-06T10:14:28.075Z] E        'dom/media/webrtc/metrics.yaml',
[task 2024-03-06T10:14:28.075Z] E     -  'dom/security/metrics.yaml',
[task 2024-03-06T10:14:28.075Z] E        'dom/metrics.yaml',
[task 2024-03-06T10:14:28.075Z] E        'dom/performance/metrics.yaml',
[task 2024-03-06T10:14:28.075Z] E     +  'dom/security/metrics.yaml',
[task 2024-03-06T10:14:28.075Z] E        'gfx/metrics.yaml',
[task 2024-03-06T10:14:28.075Z] E        'image/decoders/metrics.yaml',
[task 2024-03-06T10:14:28.075Z] E        'js/xpconnect/metrics.yaml',
[task 2024-03-06T10:14:28.075Z] E        'layout/base/metrics.yaml',
[task 2024-03-06T10:14:28.075Z] E        'mobile/android/actors/metrics.yaml',
[task 2024-03-06T10:14:28.075Z] E        'mobile/android/modules/geckoview/metrics.yaml',
[task 2024-03-06T10:14:28.075Z] E        'netwerk/metrics.yaml',
[task 2024-03-06T10:14:28.075Z] E        'netwerk/protocol/http/metrics.yaml',
[task 2024-03-06T10:14:28.075Z] E        'security/manager/ssl/metrics.yaml',
[task 2024-03-06T10:14:28.075Z] E        'toolkit/components/cookiebanners/metrics.yaml',
[task 2024-03-06T10:14:28.075Z] E        'toolkit/components/extensions/metrics.yaml',
[task 2024-03-06T10:14:28.075Z] E        'toolkit/components/formautofill/metrics.yaml',
[task 2024-03-06T10:14:28.075Z] E        'toolkit/components/glean/metrics.yaml',
[task 2024-03-06T10:14:28.075Z] E        'toolkit/components/passwordmgr/metrics.yaml',
[task 2024-03-06T10:14:28.075Z] E        'toolkit/components/pdfjs/metrics.yaml',
[task 2024-03-06T10:14:28.075Z] E        'toolkit/components/processtools/metrics.yaml',
[task 2024-03-06T10:14:28.075Z] E        'toolkit/components/reportbrokensite/metrics.yaml',
[task 2024-03-06T10:14:28.075Z] E        'toolkit/components/resistfingerprinting/metrics.yaml',
[task 2024-03-06T10:14:28.075Z] E        'toolkit/components/translations/metrics.yaml',
[task 2024-03-06T10:14:28.075Z] E        'toolkit/mozapps/extensions/metrics.yaml',
[task 2024-03-06T10:14:28.075Z] E        'toolkit/mozapps/handling/metrics.yaml',
[task 2024-03-06T10:14:28.075Z] E        'toolkit/xre/metrics.yaml',
[task 2024-03-06T10:14:28.075Z] E        'xpcom/metrics.yaml',
[task 2024-03-06T10:14:28.075Z] E       ]
[task 2024-03-06T10:14:28.075Z] ============================== 1 failed in 0.05s ===============================
```

Back to Bug 1868380 Comment 14