Bug 1868664 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
STR:
1. Open https://pontoon.mozilla.org/he/amo/all-resources/?extra=missing-without-unreviewed&string=66716, make sure you're signed in
2. Focus the text box
3. Ctrl + Shift + X (or right click on the textbox and select Switch Text Direction)

AR:
The page's layout changes instead of the textbox itself

ER:
Just the textbox direction changes.

This also happens on matrix chat (http://chat.mozilla.org/).

As per jfkthame (from #layout on matrix):
`
it looks like the flip-direction keyboard shortcut gets handled here:
https://searchfox.org/mozilla-central/rev/16526d690cccc9c60cacf09cc08e2c3041ef884e/editor/libeditor/EditorBase.cpp#5666-5692, and in the case of chat.mozilla.org, for example, it ends up setting the dir attribute on the <body> element (rather than on something closer to the focused text area). I guess this has to do with how the page is structured.
`
Revision 1 by
on 
STR:
1. Open https://pontoon.mozilla.org/he/amo/all-resources/?extra=missing-without-unreviewed&string=66716, make sure you're signed in
2. Focus the text box
3. Ctrl + Shift + X (or right click on the textbox and select Switch Text Direction)

AR:
The page's layout changes instead of the textbox itself

ER:
Just the textbox direction changes.

This also happens on matrix chat (http://chat.mozilla.org/).

As per jfkthame (from #layout on matrix):
`
it looks like the flip-direction keyboard shortcut gets handled here:
https://searchfox.org/mozilla-central/rev/16526d690cccc9c60cacf09cc08e2c3041ef884e/editor/libeditor/EditorBase.cpp#5666-5692, and in the case of chat.mozilla.org, for example, it ends up setting the dir attribute on the <body> element (rather than on something closer to the focused text area). I guess this has to do with how the page is structured.

reduced example:
data:text/html,<div>hello world</div><div style="width:50ch;border:1px solid gray" contenteditable>editable text</div><div>more text</div><input value="input element"><div>footer</div>
shift-ctrl-x in the input element flips only the input element; doing it in the contenteditable flips the entire page
`
Revision 2 by
on 
STR:
1. Open https://pontoon.mozilla.org/he/amo/all-resources/?extra=missing-without-unreviewed&string=66716, make sure you're signed in
2. Focus the text box
3. Ctrl + Shift + X (or right click on the textbox and select Switch Text Direction)

AR:
The page's layout changes instead of the textbox itself

ER:
Just the textbox direction changes.

This also happens on matrix chat (http://chat.mozilla.org/).

As per jfkthame (from #layout on matrix):
```
it looks like the flip-direction keyboard shortcut gets handled here:
https://searchfox.org/mozilla-central/rev/16526d690cccc9c60cacf09cc08e2c3041ef884e/editor/libeditor/EditorBase.cpp#5666-5692, and in the case of chat.mozilla.org, for example, it ends up setting the dir attribute on the <body> element (rather than on something closer to the focused text area). I guess this has to do with how the page is structured.

reduced example:
data:text/html,<div>hello world</div><div style="width:50ch;border:1px solid gray" contenteditable>editable text</div><div>more text</div><input value="input element"><div>footer</div>
shift-ctrl-x in the input element flips only the input element; doing it in the contenteditable flips the entire page
```
Revision 3 by
on 
STR:
1. Open https://pontoon.mozilla.org/he/amo/all-resources/?extra=missing-without-unreviewed&string=66716, make sure you're signed in
2. Focus the text box
3. Ctrl + Shift + X (or right click on the textbox and select Switch Text Direction)

AR:
The page's layout changes instead of the textbox itself

ER:
Just the textbox direction changes.

This also happens on matrix chat (http://chat.mozilla.org/).

As per jfkthame (from #layout on matrix):
```
it looks like the flip-direction keyboard shortcut gets handled here:
https://searchfox.org/mozilla-central/rev/16526d690cccc9c60cacf09cc08e2c3041ef884e/editor/libeditor/EditorBase.cpp#5666-5692
and in the case of chat.mozilla.org, for example, it ends up setting the dir attribute on the <body> element
(rather than on something closer to the focused text area). I guess this has to do with how the page is structured.

reduced example:
data:text/html,<div>hello world</div><div style="width:50ch;border:1px solid gray" contenteditable>editable text</div><div>more text</div><input value="input element"><div>footer</div>
shift-ctrl-x in the input element flips only the input element; doing it in the contenteditable flips the entire page
```

Back to Bug 1868664 Comment 0