Bug 1870570 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
We accept partial time zone and AM/PM, which other engines do not:

|Input|JavaScriptCore|SpiderMonkey|V8
|---|---|---|---
|`"9/26/95 g"`|Invalid Date|Mon Sep 25 1995 17:00:00 GMT-0700 (Mountain Standard Time)|Invalid Date
|`"9/26/95 gm"`|Invalid Date|Mon Sep 25 1995 17:00:00 GMT-0700 (Mountain Standard Time)|Invalid Date
|`"9/26/95 gmt"`|Mon Sep 25 1995 17:00:00 GMT-0700 (Mountain Standard Time)|Mon Sep 25 1995 17:00:00 GMT-0700 (Mountain Standard Time)|Mon Sep 25 1995 17:00:00 GMT-0700 (Mountain Standard Time)
|`"9/26/95 c"`|Invalid Date|Mon Sep 25 1995 22:00:00 GMT-0700 (Mountain Standard Time)|Invalid Date
|`"9/26/95 cs"`|Invalid Date|Mon Sep 25 1995 23:00:00 GMT-0700 (Mountain Standard Time)|Invalid Date
|`"9/26/95 cst"`|Mon Sep 25 1995 23:00:00 GMT-0700 (Mountain Standard Time)|Mon Sep 25 1995 23:00:00 GMT-0700 (Mountain Standard Time)|Mon Sep 25 1995 23:00:00 GMT-0700 (Mountain Standard Time)
|`"9/26/95 10:00 a"`|Invalid Date|Tue Sep 26 1995 10:00:00 GMT-0700 (Mountain Standard Time)|Invalid Date
|`"9/26/95 10:00 am"`|Tue Sep 26 1995 10:00:00 GMT-0700 (Mountain Standard Time)|Tue Sep 26 1995 10:00:00 GMT-0700 (Mountain Standard Time)|Tue Sep 26 1995 10:00:00 GMT-0700 (Mountain Standard Time)

This is causing problems making bug 1870434's patch play nice with naturalSort.

We only need to accept partial [keywords](https://searchfox.org/mozilla-central/rev/91cc8848427fdbbeb324e6ca56a0d08d32d3c308/js/src/jsdate.cpp#1321) for day of week, which it looks like we will soon be dropping support for at this point in the format, see bug 1862922. If we wish to tackle these before then, it looks like we will need to separate the day of week logic from the rest of the keywords.
Revision 1 by
on 
We accept partial time zone and AM/PM, which other engines do not:

|Input|JavaScriptCore|SpiderMonkey|V8
|---|---|---|---
|`"9/26/95 g"`|Invalid Date|Mon Sep 25 1995 17:00:00 GMT-0700 (Mountain Standard Time)|Invalid Date
|`"9/26/95 gm"`|Invalid Date|Mon Sep 25 1995 17:00:00 GMT-0700 (Mountain Standard Time)|Invalid Date
|`"9/26/95 gmt"`|Mon Sep 25 1995 17:00:00 GMT-0700 (Mountain Standard Time)|Mon Sep 25 1995 17:00:00 GMT-0700 (Mountain Standard Time)|Mon Sep 25 1995 17:00:00 GMT-0700 (Mountain Standard Time)
|`"9/26/95 c"`|Invalid Date|Mon Sep 25 1995 22:00:00 GMT-0700 (Mountain Standard Time)|Invalid Date
|`"9/26/95 cs"`|Invalid Date|Mon Sep 25 1995 23:00:00 GMT-0700 (Mountain Standard Time)|Invalid Date
|`"9/26/95 cst"`|Mon Sep 25 1995 23:00:00 GMT-0700 (Mountain Standard Time)|Mon Sep 25 1995 23:00:00 GMT-0700 (Mountain Standard Time)|Mon Sep 25 1995 23:00:00 GMT-0700 (Mountain Standard Time)
|`"9/26/95 10:00 a"`|Invalid Date|Tue Sep 26 1995 10:00:00 GMT-0700 (Mountain Standard Time)|Invalid Date
|`"9/26/95 10:00 am"`|Tue Sep 26 1995 10:00:00 GMT-0700 (Mountain Standard Time)|Tue Sep 26 1995 10:00:00 GMT-0700 (Mountain Standard Time)|Tue Sep 26 1995 10:00:00 GMT-0700 (Mountain Standard Time)

This is causing problems making bug 1870434's patch play nice with `naturalSort`.

We only need to accept partial [keywords](https://searchfox.org/mozilla-central/rev/91cc8848427fdbbeb324e6ca56a0d08d32d3c308/js/src/jsdate.cpp#1321) for day of week, which it looks like we will soon be dropping support for at this point in the format, see bug 1862922. If we wish to tackle these before then, it looks like we will need to separate the day of week logic from the rest of the keywords.

Back to Bug 1870570 Comment 0