It has been brought to the design systems team attention that our existing line height design token values can compromise certain scripts, such as Khmer, for example. Upon getting Jonathan Kew's, who specializes in fonts and scripts, feedback, we have discussed that `normal` is a better suited value and solution to guarantee proper line spacing in all languages.
Jkew's helpful feedback:
> So to clarify what normal does: it doesn't simply map to a particular number (1.2 or anything else), what it does is to look at the first available font from the font-family list -- which may be a specific named font, or may be a CSS generic like sans-serif, in which case it will be resolved depending on the Firefox font prefs and the language/locale involved -- and then computes a line height based on the metrics found in that font. For non-Latin fonts, that can end up being quite different from typical Latin values; e.g. in writing systems that use a lot of tall or "stacked-up" characters, it'll probably be quite a bit larger.
Let's make sure we only have one line height design token and that it points to `normal`.
Bug 1872788 Comment 0 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
It has been brought to the design systems team attention that our existing line height design token values can compromise certain scripts, such as Khmer, for example. Upon getting Jonathan Kew's, who specializes in fonts and scripts, feedback, we have discussed that `normal` is a better suited value and solution to guarantee proper line spacing in all languages.
Jkew's helpful feedback:
> So to clarify what normal does: it doesn't simply map to a particular number (1.2 or anything else), what it does is to look at the first available font from the font-family list -- which may be a specific named font, or may be a CSS generic like sans-serif, in which case it will be resolved depending on the Firefox font prefs and the language/locale involved -- and then computes a line height based on the metrics found in that font. For non-Latin fonts, that can end up being quite different from typical Latin values; e.g. in writing systems that use a lot of tall or "stacked-up" characters, it'll probably be quite a bit larger.
Let's make sure we get rid of line height design tokens and rely on the `normal` line height default.