Bug 1873019 Comment 14 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Ed Lee :Mardak from comment #11)
> At least in one local beta debugger session, it seems like `setScreens` is continuously being called because `languageFilteredScreens` keeps changing. If I set a breakpoint inside `useLanguageSwitcher` and hitting play/resume then checking `screens` shows it keeps switching between an array of 6 items and an array of 9 items. So the effect keeps triggering itself.
> 
> https://searchfox.org/mozilla-central/rev/6f90f50b7a32cc062ab755e0653b3d3f512fe3bd/browser/components/aboutwelcome/content-src/components/MultiStageAboutWelcome.jsx#197-207

This seems like the likely culprit, although I don't know why there seems to be a discrepancy between Nightly and Beta (unless there are no language packs compatible with nightly?) 

I logged out the this [useEffect](https://searchfox.org/mozilla-central/source/browser/components/aboutwelcome/content-src/components/MultiStageAboutWelcome.jsx#205) and it keeps firing. I logged out the dependency but on 119.0b1 it logs out the same array of 8 elements. Commenting out language switcher from AW resolves the issue but it's not obvious to me yet why the dependency is changing (or how) and what caused this to start happening in Fx119+.
(In reply to Ed Lee :Mardak from comment #11)
> At least in one local beta debugger session, it seems like `setScreens` is continuously being called because `languageFilteredScreens` keeps changing. If I set a breakpoint inside `useLanguageSwitcher` and hitting play/resume then checking `screens` shows it keeps switching between an array of 6 items and an array of 9 items. So the effect keeps triggering itself.
> 
> https://searchfox.org/mozilla-central/rev/6f90f50b7a32cc062ab755e0653b3d3f512fe3bd/browser/components/aboutwelcome/content-src/components/MultiStageAboutWelcome.jsx#197-207

This seems like the likely culprit, although I don't know why there seems to be a discrepancy between Nightly and Beta (unless there are no language packs compatible with nightly?) 

I logged out the this [useEffect](https://searchfox.org/mozilla-central/source/browser/components/aboutwelcome/content-src/components/MultiStageAboutWelcome.jsx#205) and it keeps firing. I logged out the dependency but on 119.0b1 it logs out the same array of 8 elements. Commenting out language switcher screen from AW resolves the issue but it's not obvious to me yet why the dependency is changing (or how) and what caused this to start happening in Fx119+.

Back to Bug 1873019 Comment 14