Fwiw, building firefox on OpenBSD with libcxx 19 also hits the same issue, and the patch proposed for/used by FreeBSD works for us too. with libcxx 16, i've run two builds of 140.0rc1 to compare the binaries/libraries sizes: - with `-include gcc_hidden.h` (i guess, my default build, which already yields tons of warnings but no errors): ``` -rwxr-xr-x 1 landry landry 1926488 Jun 22 07:01 firefox* -rwxr-xr-x 1 landry landry 1926488 Jun 22 07:01 firefox-bin* -rwxr-xr-x 1 landry landry 13446856 Jun 22 07:01 libgkcodecs.so.152.0* -rwxr-xr-x 1 landry landry 1745272 Jun 22 07:01 liblgpllibs.so.152.0* -rwxr-xr-x 1 landry landry 9693544 Jun 22 07:01 libmozavcodec.so.152.0* -rwxr-xr-x 1 landry landry 2237632 Jun 22 07:01 libmozavutil.so.152.0* -rwxr-xr-x 1 landry landry 7624 Jun 22 07:01 libmozgtk.so.152.0* -rwxr-xr-x 1 landry landry 7645488 Jun 22 07:01 libmozsqlite3.so.152.0* -rwxr-xr-x 1 landry landry 42752 Jun 22 07:01 libmozwayland.so.152.0* -rwxr-xr-x 1 landry landry 2182350888 Jun 22 07:14 libxul.so.152.0* $size libxul.so.152.0 htext data bss dec hex 159494725 6474440 425456 166394621 9eafafd ``` - with the patch using `fvisibility=hidden`: ``` -rwxr-xr-x 1 landry landry 1925816 Jun 22 06:31 firefox* -rwxr-xr-x 1 landry landry 1925816 Jun 22 06:31 firefox-bin* -rwxr-xr-x 1 landry landry 13446856 Jun 22 06:30 libgkcodecs.so.152.0* -rwxr-xr-x 1 landry landry 1745272 Jun 22 06:32 liblgpllibs.so.152.0* -rwxr-xr-x 1 landry landry 9692328 Jun 22 06:32 libmozavcodec.so.152.0* -rwxr-xr-x 1 landry landry 2237632 Jun 22 06:31 libmozavutil.so.152.0* -rwxr-xr-x 1 landry landry 7624 Jun 22 06:31 libmozgtk.so.152.0* -rwxr-xr-x 1 landry landry 7645488 Jun 22 06:30 libmozsqlite3.so.152.0* -rwxr-xr-x 1 landry landry 42752 Jun 22 06:31 libmozwayland.so.152.0* -rwxr-xr-x 1 landry landry 2184175328 Jun 22 06:42 libxul.so.152.0* $size libxul.so.152.0 text data bss dec hex 159479543 6475168 425848 166380559 9eac40f ``` so that's ... two megabytes less on libxul.so when using `-include gcc_hidden.h` ? `nm -g` shows the same amount of lines (5168). @glandium what else should be compared ? can we at least get something commited to unbreak libcxx builds ?
Bug 1874059 Comment 5 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Fwiw, building firefox on OpenBSD with libcxx 19 also hits the same issue, and the patch proposed for/used by FreeBSD works for us too. with libcxx 16, i've run two builds of 140.0rc1 to compare the binaries/libraries sizes: - with `-include gcc_hidden.h` (i guess, my default build, which already yields tons of warnings about undefined syms when linking but no errors): ``` -rwxr-xr-x 1 landry landry 1926488 Jun 22 07:01 firefox* -rwxr-xr-x 1 landry landry 1926488 Jun 22 07:01 firefox-bin* -rwxr-xr-x 1 landry landry 13446856 Jun 22 07:01 libgkcodecs.so.152.0* -rwxr-xr-x 1 landry landry 1745272 Jun 22 07:01 liblgpllibs.so.152.0* -rwxr-xr-x 1 landry landry 9693544 Jun 22 07:01 libmozavcodec.so.152.0* -rwxr-xr-x 1 landry landry 2237632 Jun 22 07:01 libmozavutil.so.152.0* -rwxr-xr-x 1 landry landry 7624 Jun 22 07:01 libmozgtk.so.152.0* -rwxr-xr-x 1 landry landry 7645488 Jun 22 07:01 libmozsqlite3.so.152.0* -rwxr-xr-x 1 landry landry 42752 Jun 22 07:01 libmozwayland.so.152.0* -rwxr-xr-x 1 landry landry 2182350888 Jun 22 07:14 libxul.so.152.0* $size libxul.so.152.0 htext data bss dec hex 159494725 6474440 425456 166394621 9eafafd ``` - with the patch using `fvisibility=hidden`: ``` -rwxr-xr-x 1 landry landry 1925816 Jun 22 06:31 firefox* -rwxr-xr-x 1 landry landry 1925816 Jun 22 06:31 firefox-bin* -rwxr-xr-x 1 landry landry 13446856 Jun 22 06:30 libgkcodecs.so.152.0* -rwxr-xr-x 1 landry landry 1745272 Jun 22 06:32 liblgpllibs.so.152.0* -rwxr-xr-x 1 landry landry 9692328 Jun 22 06:32 libmozavcodec.so.152.0* -rwxr-xr-x 1 landry landry 2237632 Jun 22 06:31 libmozavutil.so.152.0* -rwxr-xr-x 1 landry landry 7624 Jun 22 06:31 libmozgtk.so.152.0* -rwxr-xr-x 1 landry landry 7645488 Jun 22 06:30 libmozsqlite3.so.152.0* -rwxr-xr-x 1 landry landry 42752 Jun 22 06:31 libmozwayland.so.152.0* -rwxr-xr-x 1 landry landry 2184175328 Jun 22 06:42 libxul.so.152.0* $size libxul.so.152.0 text data bss dec hex 159479543 6475168 425848 166380559 9eac40f ``` so that's ... two megabytes less on libxul.so when using `-include gcc_hidden.h` ? `nm -g` shows the same amount of lines (5168). @glandium what else should be compared ? can we at least get something commited to unbreak libcxx builds ?